Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task]: Backfill data for existing ActivityLogs that are missing reasons. #15354

Open
2 tasks
KevinMind opened this issue Feb 11, 2025 · 0 comments
Open
2 tasks
Labels
needs:info repository:addons-frontend Issue relating to addons-frontend repository:addons-server Issue relating to addons-server

Comments

@KevinMind
Copy link
Contributor

KevinMind commented Feb 11, 2025

Description

Once we fix #15352 we'll want to backfill data to make sure past ActivityLog for actual rejections after a delay have the right ReviewActionReasons attached (through ReviewActionReasonLog - that should happen automatically when a ReviewActionReasons instance is added to the arguments of the ActivityLog), starting from 2025-01-

This should happen through a one-off management command firing a task.

Cinder decisions need to be updated as well. Each ReviewActionReason is linked to a CinderPolicy and each ContentDecision is linked to CinderPolicy through a M2M. When we create decisions in Cinder, we pass a list of policy_uuids corresponding to the policies attached to the decision. That needs to be replicated to backfill the data in Cinder - this might require a new API on their side to edit a decision, as they are not supposed to be changed so the API to do that might not exist yet.

Acceptance Criteria

Milestones/checkpoints

Preview Give feedback

Checks

  • If I have identified that the work is specific to a repository, I have removed "repository:addons-server" or "repository:addons-frontend"

┆Issue is synchronized with this Jira Task

@KevinMind KevinMind added needs:info repository:addons-server Issue relating to addons-server repository:addons-frontend Issue relating to addons-frontend labels Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs:info repository:addons-frontend Issue relating to addons-frontend repository:addons-server Issue relating to addons-server
Projects
None yet
Development

No branches or pull requests

1 participant