Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change how AMO listing pages list "More extensions by [developer]" #15287

Closed
1 task
devaneymoz opened this issue Jan 16, 2025 · 5 comments · Fixed by mozilla/addons-frontend#13442
Closed
1 task
Assignees
Labels
qa:verified_fix repository:addons-frontend Issue relating to addons-frontend repository:addons-server Issue relating to addons-server
Milestone

Comments

@devaneymoz
Copy link

devaneymoz commented Jan 16, 2025

Description

If a developer has more than one extension listed on AMO, their listing pages will automatically include a bottom-page module titled "More extensions by [developer]" that lists up to 6 additional extensions. If the developer has more than 6 extensions the module selects 6 based on a type of trending signal (i.e. surge of recent engagement).

However, we'd prefer this module list up to 6 extensions based on overall usage/popularity, as opposed to trending. Doing so will provide more visibility to the developer's most impactful content.

@abyrne-moz @diox

Acceptance Criteria

Milestones/checkpoints

Preview Give feedback

Checks

  • If I have identified that the work is specific to a repository, I have removed "repository:addons-server" or "repository:addons-frontend"

┆Issue is synchronized with this Jira Task

@devaneymoz devaneymoz added needs:info repository:addons-server Issue relating to addons-server repository:addons-frontend Issue relating to addons-frontend labels Jan 16, 2025
@abyrne-moz

This comment has been minimized.

@diox

This comment has been minimized.

@alexandruschek
Copy link

Hello,

I checked on -DEV, several addons and the "more extensions by [developer]" list. Here are two examples:
One in which only one addon from the list has more users than 0:
https://addons-dev.allizom.org/en-US/firefox/addon/all-of-the-permissions/
Image
A case with multiple addons that have a higher number of users:
https://addons-dev.allizom.org/en-US/firefox/addon/restricted-addon/
Image

And in the case of multiple developers, the addons in the list are not in the correct order or at least it looks like it:
https://addons-dev.allizom.org/en-US/firefox/addon/scenario-6/
Image

@diox If the last case is not considered an issue, then I will add the verified label. If it's an issue, please tell me so I can open a separate one if it is needed.

Thank you @diox for the help!

@diox
Copy link
Member

diox commented Feb 13, 2025

So, the last one is an edge case around multiple users, this is not new and was intended back when this feature was built.

This is happening because when there are multiple authors we show add-ons for all of them separately. The first 2 are coming from a different developer than the rest, and they both have 0 users so the order is irrelevant. The next "batch" is all from the second author and all have users to we can see the ordering works.

@alexandruschek
Copy link

Ok, marking this as verified fix. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified_fix repository:addons-frontend Issue relating to addons-frontend repository:addons-server Issue relating to addons-server
Projects
None yet
5 participants