Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task]: Refactor CinderJob and ContentDecision to allow consistent use between Cinder and reviewer tools #15220

Open
1 of 2 tasks
eviljeff opened this issue Dec 4, 2024 · 0 comments · May be fixed by mozilla/addons-server#22967
Assignees
Labels
repository:addons-server Issue relating to addons-server
Milestone

Comments

@eviljeff
Copy link
Member

eviljeff commented Dec 4, 2024

Description

Currently there are two independent code paths for a decision that's made to take down an add-on if it's taken via the reviewer tools, or taken via Cinder. Mainly because the reviewer tools carries out the action first; then logs the decision with Cinder; whereas a Cinder originated decision (obviously) has already logged the the decision; then we carry out the action.
It also allowed one workflow to be developed without considering - or regressing - the other workflow. But the duplication is a net negative in mature code, and means that implementing new features means double the engineering effort. We should bit the bullet and refactor the differences away

Acceptance Criteria

Milestones/checkpoints

Preview Give feedback

Checks

  • If I have identified that the work is specific to a repository, I have removed "repository:addons-server" or "repository:addons-frontend"

┆Issue is synchronized with this Jira Task

@eviljeff eviljeff added needs:info repository:addons-server Issue relating to addons-server labels Dec 4, 2024
@eviljeff eviljeff added this to the 2025.01.23 milestone Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
repository:addons-server Issue relating to addons-server
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant