You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently there are two independent code paths for a decision that's made to take down an add-on if it's taken via the reviewer tools, or taken via Cinder. Mainly because the reviewer tools carries out the action first; then logs the decision with Cinder; whereas a Cinder originated decision (obviously) has already logged the the decision; then we carry out the action.
It also allowed one workflow to be developed without considering - or regressing - the other workflow. But the duplication is a net negative in mature code, and means that implementing new features means double the engineering effort. We should bit the bullet and refactor the differences away
Acceptance Criteria
The content you are editing has changed. Please copy your edits and refresh the page.
Description
Currently there are two independent code paths for a decision that's made to take down an add-on if it's taken via the reviewer tools, or taken via Cinder. Mainly because the reviewer tools carries out the action first; then logs the decision with Cinder; whereas a Cinder originated decision (obviously) has already logged the the decision; then we carry out the action.
It also allowed one workflow to be developed without considering - or regressing - the other workflow. But the duplication is a net negative in mature code, and means that implementing new features means double the engineering effort. We should bit the bullet and refactor the differences away
Acceptance Criteria
Milestones/checkpoints
Checks
┆Issue is synchronized with this Jira Task
The text was updated successfully, but these errors were encountered: