Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix FXIOS-10801 Align test with TestRail #23693

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Bugfix FXIOS-10801 Align test with TestRail #23693

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9316da5
Update testBasicHTTPAuthenticationPromptVisibleAndLogin
clarmso Dec 11, 2024
c5dd9a6
🈳 Empty commit 🈳
clarmso Dec 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions firefox-ios/firefox-ios-tests/Tests/XCUITests/AuthenticationTest.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,12 +46,8 @@ class AuthenticationTest: BaseTestCase {
inaccessible after sign in to verify the success text. */
waitForNoExistence(app.alerts.buttons["Cancel"], timeoutValue: 5)
waitForNoExistence(app.alerts.buttons["Log in"], timeoutValue: 5)
// Added this check to ensure the BasicAuth login is persisting after app restart as well.
app.terminate()
app.launch()
navigator.openURL(testBasicHTTPAuthURL)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some reason, I have to reload the URL after entering the username and password to have the website loaded. I can reproduce the same issue from one other basic auth testing site (https://httpbin.org/#/Auth/get_basic_auth__user___passwd_).

Bug or not a bug?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you ask me, I would say is a bug but maybe we should ask the product team

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume this is the bug reported by you @clarmso for this: #23565

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i am in favor for an workaround and make this test pass, but lets make sure after the bug is fixed the test fails in order to remove it

Copy link
Contributor

@isabelrios isabelrios Dec 12, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would say it is a bug since this test has been passing consistently. @clarmso can you please open an issue and clarify that? let's hold on landing this workaround in the meantime

mozWaitForElementToExist(app.textFields[AccessibilityIdentifiers.Browser.AddressToolbar.searchTextField])
navigator.nowAt(NewTabScreen)
waitUntilPageLoad()
mozWaitForElementToExist(app.webViews["Web content"].staticTexts["Your browser made it!"])
}
}