-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix FXIOS-10801 Align test with TestRail #23693
base: main
Are you sure you want to change the base?
Conversation
@@ -46,12 +46,8 @@ class AuthenticationTest: BaseTestCase { | |||
inaccessible after sign in to verify the success text. */ | |||
waitForNoExistence(app.alerts.buttons["Cancel"], timeoutValue: 5) | |||
waitForNoExistence(app.alerts.buttons["Log in"], timeoutValue: 5) | |||
// Added this check to ensure the BasicAuth login is persisting after app restart as well. | |||
app.terminate() | |||
app.launch() | |||
navigator.openURL(testBasicHTTPAuthURL) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For some reason, I have to reload the URL after entering the username and password to have the website loaded. I can reproduce the same issue from one other basic auth testing site (https://httpbin.org/#/Auth/get_basic_auth__user___passwd_).
Bug or not a bug?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you ask me, I would say is a bug but maybe we should ask the product team
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i am in favor for an workaround and make this test pass, but lets make sure after the bug is fixed the test fails in order to remove it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would say it is a bug since this test has been passing consistently. @clarmso can you please open an issue and clarify that? let's hold on landing this workaround in the meantime
Generated by 🚫 Danger Swift against c5dd9a6 |
📜 Tickets
Jira ticket
💡 Description
The test case from TestRail just checks if the login prompt appears.
📝 Checklist
You have to check all boxes before merging
@Mergifyio backport release/v120
)