Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix FXIOS-10801 Align test with TestRail #23693

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

clarmso
Copy link
Collaborator

@clarmso clarmso commented Dec 11, 2024

📜 Tickets

Jira ticket

💡 Description

The test case from TestRail just checks if the login prompt appears.

📝 Checklist

You have to check all boxes before merging

  • Filled in the above information (tickets numbers and description of your work)
  • Updated the PR name to follow our PR naming guidelines
  • Wrote unit tests and/or ensured the tests suite is passing
  • When working on UI, I checked and implemented accessibility (minimum Dynamic Text and VoiceOver)
  • If needed, I updated documentation / comments for complex code and public methods
  • If needed, added a backport comment (example @Mergifyio backport release/v120)

@clarmso clarmso requested a review from a team as a code owner December 11, 2024 18:48
@@ -46,12 +46,8 @@ class AuthenticationTest: BaseTestCase {
inaccessible after sign in to verify the success text. */
waitForNoExistence(app.alerts.buttons["Cancel"], timeoutValue: 5)
waitForNoExistence(app.alerts.buttons["Log in"], timeoutValue: 5)
// Added this check to ensure the BasicAuth login is persisting after app restart as well.
app.terminate()
app.launch()
navigator.openURL(testBasicHTTPAuthURL)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some reason, I have to reload the URL after entering the username and password to have the website loaded. I can reproduce the same issue from one other basic auth testing site (https://httpbin.org/#/Auth/get_basic_auth__user___passwd_).

Bug or not a bug?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you ask me, I would say is a bug but maybe we should ask the product team

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume this is the bug reported by you @clarmso for this: #23565

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i am in favor for an workaround and make this test pass, but lets make sure after the bug is fixed the test fails in order to remove it

Copy link
Contributor

@isabelrios isabelrios Dec 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would say it is a bug since this test has been passing consistently. @clarmso can you please open an issue and clarify that? let's hold on landing this workaround in the meantime

@mobiletest-ci-bot
Copy link

Messages
📖 Edited 1 files
📖 Created 0 files

Generated by 🚫 Danger Swift against c5dd9a6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants