Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Toolbar redesign] - long press options list not displayed on pdf link #23473

Open
dragosb01 opened this issue Nov 29, 2024 · 1 comment
Open
Assignees
Labels
Bug 🐞 This is a bug with existing functionality not behaving as expected eng:automation This is a task or bug affecting the automated tests eng:bug-auto-found Bug found via automated tests Regression Toolbar redesign📲 Used to track the Toolbar Redesign bugs

Comments

@dragosb01
Copy link
Collaborator

dragosb01 commented Nov 29, 2024

Steps to reproduce

  1. Open PDF website that has a link
  2. Long press on a link

Expected behavior

A list of options should be displayed (see screenshot) - Open, Add to Reading List, Copy Link, Share…

Actual behavior

The list of options is displayed only after the pressing is released.
To note that on iPad the options are displayed during the pressing action
From the screenshot notice that we also display "Copy" and "Select All" options
This might not be user friendly and redundant at least having 2 copy options

Device & build information

  • Device: iPhone 16+ (18.1) simulator
  • Build version: 134, 135
  • First seen version: Yes

Notes

Issue started to reproduce after the toolbar redesign experiment was enabled
Automation test affected: testLongPressOnPDFLink, testLongPressOnPDFLinkToAddToReadingList
https://mozilla.testrail.io/index.php?/cases/view/2307118
Attachments:
Screenshot 2024-11-29 at 15 32 38

┆Issue is synchronized with this Jira Task

@dragosb01 dragosb01 added Bug 🐞 This is a bug with existing functionality not behaving as expected eng:automation This is a task or bug affecting the automated tests Regression eng:bug-auto-found Bug found via automated tests Toolbar redesign📲 Used to track the Toolbar Redesign bugs labels Nov 29, 2024
@dicarobinho dicarobinho self-assigned this Nov 29, 2024
@dicarobinho
Copy link
Collaborator

After investigations, this seems to be an issue from the OS. I was able to reproduce this on a Webview demo project. Also on Chrome we can see the same behaviour.

Screen.Recording.2024-12-02.at.11.55.59.mov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug 🐞 This is a bug with existing functionality not behaving as expected eng:automation This is a task or bug affecting the automated tests eng:bug-auto-found Bug found via automated tests Regression Toolbar redesign📲 Used to track the Toolbar Redesign bugs
Projects
None yet
Development

No branches or pull requests

2 participants