From 19d845361dc6ad67e7829d073aec33f59759aacc Mon Sep 17 00:00:00 2001 From: lmarceau Date: Thu, 21 Sep 2023 08:22:50 -0400 Subject: [PATCH] Add FXIOS-7348 [v119] create subgroups with extension (#16519) * Add extensions for each components So we can add images for each, and link view model * Fix todo in search view controller. Was outdated of 2015 * Typo * Rename file --- .../Building Blocks/ActionButton.md | 7 +++++++ .../Building Blocks/FadeScrollView.md | 7 +++++++ .../Building Blocks/ResizableButton.md | 8 ++++++++ .../General Components/ActionFooterView.md | 13 +++++++++++++ .../BottomSheetViewController.md | 19 +++++++++++++++++++ .../General Components/CardView.md | 13 +++++++++++++ .../General Components/CollapsibleCardView.md | 13 +++++++++++++ .../General Components/ContextualHintView.md | 13 +++++++++++++ .../PrimaryRoundedButton.md | 13 +++++++++++++ .../SecondaryRoundedButton.md | 13 +++++++++++++ .../General Components/ShadowCardView.md | 13 +++++++++++++ .../Browser/SearchViewController.swift | 3 +-- 12 files changed, 133 insertions(+), 2 deletions(-) create mode 100644 BrowserKit/Sources/ComponentLibrary/Documentation.docc/Building Blocks/ActionButton.md create mode 100644 BrowserKit/Sources/ComponentLibrary/Documentation.docc/Building Blocks/FadeScrollView.md create mode 100644 BrowserKit/Sources/ComponentLibrary/Documentation.docc/Building Blocks/ResizableButton.md create mode 100644 BrowserKit/Sources/ComponentLibrary/Documentation.docc/General Components/ActionFooterView.md create mode 100644 BrowserKit/Sources/ComponentLibrary/Documentation.docc/General Components/BottomSheetViewController.md create mode 100644 BrowserKit/Sources/ComponentLibrary/Documentation.docc/General Components/CardView.md create mode 100644 BrowserKit/Sources/ComponentLibrary/Documentation.docc/General Components/CollapsibleCardView.md create mode 100644 BrowserKit/Sources/ComponentLibrary/Documentation.docc/General Components/ContextualHintView.md create mode 100644 BrowserKit/Sources/ComponentLibrary/Documentation.docc/General Components/PrimaryRoundedButton.md create mode 100644 BrowserKit/Sources/ComponentLibrary/Documentation.docc/General Components/SecondaryRoundedButton.md create mode 100644 BrowserKit/Sources/ComponentLibrary/Documentation.docc/General Components/ShadowCardView.md diff --git a/BrowserKit/Sources/ComponentLibrary/Documentation.docc/Building Blocks/ActionButton.md b/BrowserKit/Sources/ComponentLibrary/Documentation.docc/Building Blocks/ActionButton.md new file mode 100644 index 000000000000..1a8d0c0de0f3 --- /dev/null +++ b/BrowserKit/Sources/ComponentLibrary/Documentation.docc/Building Blocks/ActionButton.md @@ -0,0 +1,7 @@ +# ``ComponentLibrary/ActionButton`` + +TODO with FXIOS-7451 + +## Overview + +TODO with FXIOS-7451 diff --git a/BrowserKit/Sources/ComponentLibrary/Documentation.docc/Building Blocks/FadeScrollView.md b/BrowserKit/Sources/ComponentLibrary/Documentation.docc/Building Blocks/FadeScrollView.md new file mode 100644 index 000000000000..28dce2c0821f --- /dev/null +++ b/BrowserKit/Sources/ComponentLibrary/Documentation.docc/Building Blocks/FadeScrollView.md @@ -0,0 +1,7 @@ +# ``ComponentLibrary/FadeScrollView`` + +TODO with FXIOS-7451 + +## Overview + +TODO with FXIOS-7451 diff --git a/BrowserKit/Sources/ComponentLibrary/Documentation.docc/Building Blocks/ResizableButton.md b/BrowserKit/Sources/ComponentLibrary/Documentation.docc/Building Blocks/ResizableButton.md new file mode 100644 index 000000000000..a42be3ab1b22 --- /dev/null +++ b/BrowserKit/Sources/ComponentLibrary/Documentation.docc/Building Blocks/ResizableButton.md @@ -0,0 +1,8 @@ +# ``ComponentLibrary/ResizableButton`` + +TODO with FXIOS-7451 + +## Overview + +TODO with FXIOS-7451 + diff --git a/BrowserKit/Sources/ComponentLibrary/Documentation.docc/General Components/ActionFooterView.md b/BrowserKit/Sources/ComponentLibrary/Documentation.docc/General Components/ActionFooterView.md new file mode 100644 index 000000000000..9f5f997e1b3f --- /dev/null +++ b/BrowserKit/Sources/ComponentLibrary/Documentation.docc/General Components/ActionFooterView.md @@ -0,0 +1,13 @@ +# ``ComponentLibrary/ActionFooterView`` + +TODO with FXIOS-7437 + +## Overview + +TODO with FXIOS-7437 + +## Topics + +### View Model + +- ``ActionFooterViewModel`` diff --git a/BrowserKit/Sources/ComponentLibrary/Documentation.docc/General Components/BottomSheetViewController.md b/BrowserKit/Sources/ComponentLibrary/Documentation.docc/General Components/BottomSheetViewController.md new file mode 100644 index 000000000000..18505cf8c214 --- /dev/null +++ b/BrowserKit/Sources/ComponentLibrary/Documentation.docc/General Components/BottomSheetViewController.md @@ -0,0 +1,19 @@ +# ``ComponentLibrary/BottomSheetViewController`` + +TODO with FXIOS-7431 + +## Overview + +TODO with FXIOS-7431 + +## Topics + +### View Model + +- ``BottomSheetViewModel`` + +### Protocols + +- ``BottomSheetChild`` +- ``BottomSheetDismissProtocol`` + diff --git a/BrowserKit/Sources/ComponentLibrary/Documentation.docc/General Components/CardView.md b/BrowserKit/Sources/ComponentLibrary/Documentation.docc/General Components/CardView.md new file mode 100644 index 000000000000..26050f1aa0a6 --- /dev/null +++ b/BrowserKit/Sources/ComponentLibrary/Documentation.docc/General Components/CardView.md @@ -0,0 +1,13 @@ +# ``ComponentLibrary/CardView`` + +TODO with FXIOS-7434 + +## Overview + +TODO with FXIOS-7434 + +## Topics + +### View Model + +- ``CardViewModel`` diff --git a/BrowserKit/Sources/ComponentLibrary/Documentation.docc/General Components/CollapsibleCardView.md b/BrowserKit/Sources/ComponentLibrary/Documentation.docc/General Components/CollapsibleCardView.md new file mode 100644 index 000000000000..baa9457e13aa --- /dev/null +++ b/BrowserKit/Sources/ComponentLibrary/Documentation.docc/General Components/CollapsibleCardView.md @@ -0,0 +1,13 @@ +# ``ComponentLibrary/CollapsibleCardView`` + +TODO with FXIOS-7435 + +## Overview + +TODO with FXIOS-7435 + +## Topics + +### View Model + +- ``CollapsibleCardViewModel`` diff --git a/BrowserKit/Sources/ComponentLibrary/Documentation.docc/General Components/ContextualHintView.md b/BrowserKit/Sources/ComponentLibrary/Documentation.docc/General Components/ContextualHintView.md new file mode 100644 index 000000000000..1aa4e0b74a36 --- /dev/null +++ b/BrowserKit/Sources/ComponentLibrary/Documentation.docc/General Components/ContextualHintView.md @@ -0,0 +1,13 @@ +# ``ComponentLibrary/ContextualHintView`` + +TODO with FXIOS-7433 + +## Overview + +TODO with FXIOS-7433 + +## Topics + +### View Model + +- ``ContextualHintViewModel`` diff --git a/BrowserKit/Sources/ComponentLibrary/Documentation.docc/General Components/PrimaryRoundedButton.md b/BrowserKit/Sources/ComponentLibrary/Documentation.docc/General Components/PrimaryRoundedButton.md new file mode 100644 index 000000000000..4b31284c4b7d --- /dev/null +++ b/BrowserKit/Sources/ComponentLibrary/Documentation.docc/General Components/PrimaryRoundedButton.md @@ -0,0 +1,13 @@ +# ``ComponentLibrary/PrimaryRoundedButton`` + +TODO with FXIOS-7432 + +## Overview + +TODO with FXIOS-7432 + +## Topics + +### View Model + +- ``PrimaryRoundedButtonViewModel`` diff --git a/BrowserKit/Sources/ComponentLibrary/Documentation.docc/General Components/SecondaryRoundedButton.md b/BrowserKit/Sources/ComponentLibrary/Documentation.docc/General Components/SecondaryRoundedButton.md new file mode 100644 index 000000000000..98298f0ca642 --- /dev/null +++ b/BrowserKit/Sources/ComponentLibrary/Documentation.docc/General Components/SecondaryRoundedButton.md @@ -0,0 +1,13 @@ +# ``ComponentLibrary/SecondaryRoundedButton`` + +TODO with FXIOS-7432 + +## Overview + +TODO with FXIOS-7432 + +## Topics + +### View Model + +- ``SecondaryRoundedButtonViewModel`` diff --git a/BrowserKit/Sources/ComponentLibrary/Documentation.docc/General Components/ShadowCardView.md b/BrowserKit/Sources/ComponentLibrary/Documentation.docc/General Components/ShadowCardView.md new file mode 100644 index 000000000000..711d46c15905 --- /dev/null +++ b/BrowserKit/Sources/ComponentLibrary/Documentation.docc/General Components/ShadowCardView.md @@ -0,0 +1,13 @@ +# ``ComponentLibrary/ShadowCardView`` + +TODO with FXIOS-7436 + +## Overview + +TODO with FXIOS-7436 + +## Topics + +### View Model + +- ``ShadowCardViewModel`` diff --git a/Client/Frontend/Browser/SearchViewController.swift b/Client/Frontend/Browser/SearchViewController.swift index 4a518a8596a8..c46341ad525b 100644 --- a/Client/Frontend/Browser/SearchViewController.swift +++ b/Client/Frontend/Browser/SearchViewController.swift @@ -19,8 +19,7 @@ private enum SearchListSection: Int, CaseIterable { } private struct SearchViewControllerUX { - // TODO: This should use ToolbarHeight in BVC. Fix this when we create a shared theming file. - static let EngineButtonHeight: Float = 44 + static let EngineButtonHeight: Float = 44 // Equivalent to toolbar height, fixed at the moment static let EngineButtonWidth = EngineButtonHeight * 1.4 static let EngineButtonBackgroundColor = UIColor.clear.cgColor