Skip to content

Commit

Permalink
Add FXIOS-7348 [v119] create subgroups with extension (#16519)
Browse files Browse the repository at this point in the history
* Add extensions for each components

So we can add images for each, and link view model

* Fix todo in search view controller. Was outdated of 2015

* Typo

* Rename file
  • Loading branch information
lmarceau authored Sep 21, 2023
1 parent eb18123 commit 19d8453
Show file tree
Hide file tree
Showing 12 changed files with 133 additions and 2 deletions.
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
# ``ComponentLibrary/ActionButton``

TODO with FXIOS-7451

## Overview

TODO with FXIOS-7451
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
# ``ComponentLibrary/FadeScrollView``

TODO with FXIOS-7451

## Overview

TODO with FXIOS-7451
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
# ``ComponentLibrary/ResizableButton``

TODO with FXIOS-7451

## Overview

TODO with FXIOS-7451

Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
# ``ComponentLibrary/ActionFooterView``

TODO with FXIOS-7437

## Overview

TODO with FXIOS-7437

## Topics

### View Model

- ``ActionFooterViewModel``
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
# ``ComponentLibrary/BottomSheetViewController``

TODO with FXIOS-7431

## Overview

TODO with FXIOS-7431

## Topics

### View Model

- ``BottomSheetViewModel``

### Protocols

- ``BottomSheetChild``
- ``BottomSheetDismissProtocol``

Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
# ``ComponentLibrary/CardView``

TODO with FXIOS-7434

## Overview

TODO with FXIOS-7434

## Topics

### View Model

- ``CardViewModel``
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
# ``ComponentLibrary/CollapsibleCardView``

TODO with FXIOS-7435

## Overview

TODO with FXIOS-7435

## Topics

### View Model

- ``CollapsibleCardViewModel``
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
# ``ComponentLibrary/ContextualHintView``

TODO with FXIOS-7433

## Overview

TODO with FXIOS-7433

## Topics

### View Model

- ``ContextualHintViewModel``
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
# ``ComponentLibrary/PrimaryRoundedButton``

TODO with FXIOS-7432

## Overview

TODO with FXIOS-7432

## Topics

### View Model

- ``PrimaryRoundedButtonViewModel``
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
# ``ComponentLibrary/SecondaryRoundedButton``

TODO with FXIOS-7432

## Overview

TODO with FXIOS-7432

## Topics

### View Model

- ``SecondaryRoundedButtonViewModel``
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
# ``ComponentLibrary/ShadowCardView``

TODO with FXIOS-7436

## Overview

TODO with FXIOS-7436

## Topics

### View Model

- ``ShadowCardViewModel``
3 changes: 1 addition & 2 deletions Client/Frontend/Browser/SearchViewController.swift
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,7 @@ private enum SearchListSection: Int, CaseIterable {
}

private struct SearchViewControllerUX {
// TODO: This should use ToolbarHeight in BVC. Fix this when we create a shared theming file.
static let EngineButtonHeight: Float = 44
static let EngineButtonHeight: Float = 44 // Equivalent to toolbar height, fixed at the moment
static let EngineButtonWidth = EngineButtonHeight * 1.4
static let EngineButtonBackgroundColor = UIColor.clear.cgColor

Expand Down

0 comments on commit 19d8453

Please sign in to comment.