-
Notifications
You must be signed in to change notification settings - Fork 554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix overriding binary install #1928
Labels
good first issue
Good for newcomers
Comments
@tylerjw I think we can close this issue as it is already merged. |
I do not believe the linked to PR fixed this for the whole codebase. |
Hi @tylerjw I really would like to work on this. can I? |
@mariobo8 Yes, go for it. |
This was referenced Jan 29, 2024
This was referenced Feb 23, 2024
Closed
Closed
Closed
is this issue still open? |
Duplicate of #3134 which has more recent documentation to work from |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Overriding is when you build a package from a source that is also installed as a binary. Currently, this does not work in MoveIt because of the way header files are found. The problem is that the binary header is found before the source header when building and if the source one is newer and has changes the compile will break in surprising ways.
#1901 is a good example of what needs to be done everywhere in moveit.
Here are the colcon docs on overriding: https://colcon.readthedocs.io/en/released/user/overriding-packages.html#how-to-make-it-easier-for-your-users-to-override
Tasks:
The text was updated successfully, but these errors were encountered: