Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix overriding binary install #1928

Closed
2 tasks
tylerjw opened this issue Feb 3, 2023 · 6 comments
Closed
2 tasks

Fix overriding binary install #1928

tylerjw opened this issue Feb 3, 2023 · 6 comments
Labels
good first issue Good for newcomers

Comments

@tylerjw
Copy link
Member

tylerjw commented Feb 3, 2023

Overriding is when you build a package from a source that is also installed as a binary. Currently, this does not work in MoveIt because of the way header files are found. The problem is that the binary header is found before the source header when building and if the source one is newer and has changes the compile will break in surprising ways.

#1901 is a good example of what needs to be done everywhere in moveit.

Here are the colcon docs on overriding: https://colcon.readthedocs.io/en/released/user/overriding-packages.html#how-to-make-it-easier-for-your-users-to-override

Tasks:

  • Search for cmake files that are missing this package directory
  • Make PR fixing the issue
@tylerjw tylerjw added the good first issue Good for newcomers label Feb 3, 2023
@bailaC
Copy link
Contributor

bailaC commented May 30, 2023

@tylerjw I think we can close this issue as it is already merged.

@tylerjw
Copy link
Member Author

tylerjw commented May 30, 2023

I do not believe the linked to PR fixed this for the whole codebase.

@mariobo8
Copy link

Hi @tylerjw I really would like to work on this. can I?

@sjahr
Copy link
Contributor

sjahr commented Dec 11, 2023

@mariobo8 Yes, go for it.

@advait-zx
Copy link

is this issue still open?

@mikeferguson
Copy link
Contributor

Duplicate of #3134 which has more recent documentation to work from

@github-project-automation github-project-automation bot moved this to ✅ Done in MoveIt Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants