fix(pwa): reject malformed signed cookies (#68)

Author: aiirvizionz

apps/pwa/src/lib/crypto.mjs

@@ -37,7 +37,9 @@ export function sign(value) {
 
 export function unsign(signed) {
   if (!signed || typeof signed !== "string" || !signed.includes(".")) return null;
-  const [payload, mac] = signed.split(".");
+  const parts = signed.split(".");
+  if (parts.length !== 2) return null;
+  const [payload, mac] = parts;
   const expected = crypto.createHmac("sha256", config.sessionSecret).update(payload).digest("base64url");
   const a = Buffer.from(mac);
   const b = Buffer.from(expected);

apps/pwa/test/crypto-cookie.test.mjs

@@ -0,0 +1,15 @@
+import assert from "node:assert/strict";
+import test from "node:test";
+import { sign, unsign } from "../src/lib/crypto.mjs";
+
+test("unsign accepts an untouched signed cookie value", () => {
+  const signed = sign({ step: "passkey", nonce: "abc" });
+
+  assert.deepEqual(unsign(signed), { step: "passkey", nonce: "abc" });
+});
+
+test("unsign rejects signed cookie values with extra segments", () => {
+  const signed = sign({ step: "passkey", nonce: "abc" });
+
+  assert.equal(unsign(`${signed}.junk`), null);
+});