Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential lingering issues with XYZ files #678

Open
mattwthompson opened this issue Feb 4, 2020 · 0 comments
Open

Potential lingering issues with XYZ files #678

mattwthompson opened this issue Feb 4, 2020 · 0 comments

Comments

@mattwthompson
Copy link
Member

Copying from Parashara's comment

Just comparing with MDTraj:

  • MDTraj includes the date/time the file was created in the header. It could be cool to include that, but totally unnecessary
  • MDTraj uses 3 decimal places. Looks like some formats only accept 3? (https://open-babel.readthedocs.io/en/latest/FileFormats/XYZ_cartesian_coordinates_format.html). Not sure if this is something we care about, but it might be nice to include a n_decimal_places kwarg for the saver.
  • The xyz values for a water box mbuild system are slightly different when using MDTraj vs the new xyz saver. This is probably due to the extra decimal places in each of the xyz files saved before the PACKMOL run. Not an issue, but good to note in case someone is trying to exactly replicate a result.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants