Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unit cell/ Lattice code duplication #574

Open
justinGilmer opened this issue Aug 8, 2019 · 0 comments
Open

Unit cell/ Lattice code duplication #574

justinGilmer opened this issue Aug 8, 2019 · 0 comments
Assignees
@justinGilmer

Comments

@justinGilmer
Copy link
Contributor

justinGilmer commented Aug 8, 2019 •
edited
Loading

One thing I will comment on is that we are now using this code in a few places (lattice and here at least). This should be moved into a separate function to minimize code duplication.

Originally posted by @justinGilmer in #555

Actual Link to my comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@justinGilmer justinGilmer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@justinGilmer