Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

String validation #524

Open
ahy3nz opened this issue Apr 24, 2019 · 3 comments
Open

String validation #524

ahy3nz opened this issue Apr 24, 2019 · 3 comments

Comments

@ahy3nz
Copy link
Contributor

ahy3nz commented Apr 24, 2019

Describe the behavior you would like added to mBuild
After atomtyping with an FFXML, the resultant structure.atoms might have names that are very long strings. When writing to a fixed-column-width format, these names get truncated, which could raise issues when trying to perform a simulation

Describe the solution you'd like
Some string validation checks. The best solution isn't apparent because we use parmed's gro/pdb writers, but could we do some iteration through a pmd.Structure or mb.Compound to check string lengths?

Describe alternatives you've considered
While this isn't an absolutely essential feature, other workarounds could include making sure someone's FFXML will indeed fit their file format constraints, preventing the issue of too-long-strings. For example, making sure every type, class, element XML attribute is within the 4-char limit for PDB atoms

@mattwthompson
Copy link
Member

Correct me if I'm confused, but this seems like more of a backend issue?

@ahy3nz
Copy link
Contributor Author

ahy3nz commented Apr 24, 2019

I wasn't sure where to put this issue - the writers are in mbuild, but the validation would mainly be on parmed structures post-ff-application. Maybe there's not some code/module we can put to address this, but just observe this as a potential obstacle for users interested in using mosdef with their workflows

@CalCraven
Copy link
Contributor

This issue will in the future be a GMSO one as writing through ParmED will be deprecated. This gives us more control over these tests, which should be on the writer end of things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants