Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows testing issues #1226

Open
CalCraven opened this issue Feb 20, 2025 · 2 comments
Open

Windows testing issues #1226

CalCraven opened this issue Feb 20, 2025 · 2 comments

Comments

@CalCraven
Copy link
Contributor

Bug summary

The testing suite we use includes a windows-latest test set, that is difficult to maintain because some of the dependenceis (notably packmol) do not test specifically for windows and sometimes do not behave the same as the Ubuntu-latest tests.

I think across the MoSDeF packages, we can discuss how we want to handle Windows installs, especially because universal accomodation for WSL seems to be available to Windows users.

As an example of this behavior, #1223 is failing with the pbc keyword.

@CalCraven
Copy link
Contributor Author

Here is explicitly where they mention not testing windows in their CI.
https://github.com/m3g/packmol/blob/d7585c7633696491808b0f846dab7d2ee17f3588/.github/workflows/actions.yml#L13

@chrisjonesBSU
Copy link
Contributor

chrisjonesBSU commented Feb 20, 2025

I think we can drop windows testing with the prevalence of WSL.

While ubuntu tests in the CI are probably safe enough to test WSL usage, we could still add a workflow to the CI that runs on windows-latest using WSL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants