Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android - SDK 51 - 'getJSIModulePackage' overrides nothing #45

Open
maximedeoliveira opened this issue May 20, 2024 · 11 comments
Open

Android - SDK 51 - 'getJSIModulePackage' overrides nothing #45

maximedeoliveira opened this issue May 20, 2024 · 11 comments

Comments

@maximedeoliveira
Copy link

Context

I have upgraded my application to Expo SDK 51, when I'm trying to build android, I have the following error :

MainApplication.kt:40:9 'getJSIModulePackage' overrides nothing

I have also tried to set "disableJSI": true inside the configuration, but it throws the same error.

Version

{
  "@morrowdigital/watermelondb-expo-plugin": "^2.3.2",
  "@nozbe/watermelondb": "^0.27.1",
  "expo": "~51.0.8",
  "expo-build-properties": "~0.12.1",
}

Reproduction

A reproduction is available here : https://github.com/maximedeoliveira/expo-watermelon-android

@alexandre1921
Copy link

Same error on my app.

@alexandre1921
Copy link

alexandre1921 commented May 23, 2024

I think this is related to this: react native release-0.74#other-breaking-changes
image
So, I think the solution will take time.

@alexandre1921
Copy link

alexandre1921 commented May 23, 2024

On my app, I found a workroud, disable JSI and remove the getJSIModulePackage method on /android/app/src/main/java/com/yourapp/MainApplication.kt:40:9 and make another build:
image

@killerchip
Copy link
Contributor

Apologies guys, had no time to look into this yet.
I suspect that this is something that WMDB has to fix first and then we update this plugin for the configuration.

@killerchip
Copy link
Contributor

On my app, I found a workroud, disable JSI and remove the getJSIModulePackage method on /android/app/src/main/java/com/yourapp/MainApplication.kt:40:9 and make another build: image

Thanks @alexandre1921 .
If you disable the JSI indeed it builds (as a workaround currently)

But you don't have to manually adjust the MainApplication.kt file.
There is an error in our documentation.

To disable JSI you have to add:
["@morrowdigital/watermelondb-expo-plugin", { "disableJsi": true }],
in the app.json and not disableJSI as stated in the README.md.

Will fix the documentation...
And then try to find a solution to be able to enable JSI again.

@dasjn
Copy link

dasjn commented Aug 11, 2024

Hi @killerchip, have you been able to find a solution for the higher versions? I'm having the same problem with version 51. Thanks

@HieronymusLex
Copy link

@dasjn I believe WatermelonDB will first have to resolve Nozbe/WatermelonDB#1769 in order for this plugin to support v51+ with JSI support since 0.74 introduced a breaking change to remove getJSIModulePackage

@pritamp17
Copy link

did anyone found solution for this ?

@branaust
Copy link

branaust commented Nov 1, 2024

getting this issue as well

@aledebla03
Copy link

same issue

@branaust
Copy link

branaust commented Nov 1, 2024

I opened a PR: #50

However, I have minimal experience with native modules. I'm hoping someone with experience can hop in and take over

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants