Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When using OneClickMenu configuration option, clicking anywhere in the menu bar activates menu selection even if a menu label/icon wasn't clicked #51

Open
morgant opened this issue Nov 18, 2024 · 1 comment
Assignees
Labels
Milestone

Comments

@morgant
Copy link
Owner

morgant commented Nov 18, 2024

In troubleshooting some issues with custom applications "swallowed" into the mlvwm menu bar, I've discovered that -- if one is using the OneClickMenu configuration option which keeps menus open until a second click -- clicking anywhere in the menu bar activates the menu selection, even if the initial click was not on a menu label/icon. Most applications swallowed into the menu bar are just for display/informational purposes (e.g. xload, xmem, mlclock, etc.) so this is a non-issue, but I'm starting to add/implement more clickable applications, including some that implement their own menus (e.g. xsndiomenu). In this case, the first click on the application in the menu bar can be caught by mlvwm's menu handling, requiring a second click to complete the menu handling and then get passed to the swallowed application.

@morgant morgant added the bug label Nov 18, 2024
@morgant morgant added this to the 0.9.5 milestone Nov 18, 2024
@morgant morgant self-assigned this Nov 18, 2024
@morgant
Copy link
Owner Author

morgant commented Nov 18, 2024

My initial triaging hints at this being handled in menus.c's press_menu(), which is called from event.c's handle_button_press(), though this will need to be confirmed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant