New release planned?

[sid-6581]

It's been a while since the last release, and some useful things like nullable support seems to have already been added but not published. Is there a new release planned, or any way to get alpha/beta nuget packages?

[atifaziz]

A release has been overdue since quite some time now and while the 3.4.0 milestone has no open items, I did want to give the nullability annotations another review in light of recent developments. Lacking the time to do that is probably what's keeping me from getting it out the door. While I can't commit to any deadline…

or any way to get alpha/beta nuget packages?

CI builds are published at: https://www.myget.org/F/morelinq/api/v3/index.json

[atifaziz]

That's a really good catch and seems to have been an oversight that slipped out of PR #582.

There are other instances like this one,, as well as other similar issues.

I ran a quick and approximate grep for just IEqualityComparer:

git grep IEqualityComparer MoreLinq | grep -v /// | grep -v -F ?

and you're right:

MoreLinq/Collections/Dictionary.cs:        public Dictionary(IEqualityComparer<TKey> comparer)
MoreLinq/CountBy.cs:                void Loop(IEqualityComparer<TKey> cmp)
MoreLinq/Extensions.g.cs:            IEqualityComparer<TKey> comparer)
MoreLinq/Extensions.g.cs:            IEqualityComparer<TKey> comparer)
MoreLinq/Extensions.g.cs:            TSource separator, IEqualityComparer<TSource> comparer,
MoreLinq/FullGroupJoin.cs:            IEqualityComparer<TKey> comparer)
MoreLinq/FullGroupJoin.cs:            IEqualityComparer<TKey> comparer)
MoreLinq/FullGroupJoin.cs:            IEnumerable<TResult> _(IEqualityComparer<TKey> comparer)
MoreLinq/GroupAdjacent.cs:            IEqualityComparer<TKey> comparer)
MoreLinq/Lookup.cs:        private IEqualityComparer<TKey> _comparer;
MoreLinq/Lookup.cs:        internal static Lookup<TKey, TElement> Create<TSource>(IEnumerable<TSource> source, Func<TSource, TKey> keySelector, Func<TSource, TElement> elementSelector, IEqualityComparer<TKey> comparer)
MoreLinq/Lookup.cs:        internal static Lookup<TKey, TElement> CreateForJoin(IEnumerable<TElement> source, Func<TElement, TKey> keySelector, IEqualityComparer<TKey> comparer)
MoreLinq/Lookup.cs:        private Lookup(IEqualityComparer<TKey> comparer)
MoreLinq/RunLengthEncode.cs:            IEnumerable<KeyValuePair<T, int>> _(IEqualityComparer<T> comparer)
MoreLinq/ScanBy.cs:            IEnumerable<KeyValuePair<TKey, TState>> _(IEqualityComparer<TKey> comparer)
MoreLinq/Split.cs:            TSource separator, IEqualityComparer<TSource> comparer,

If so, I can hunt these down and try to clean them up in a PR. Just wanted to make sure I'm on the right track, …

While not all might apply, you seem to be on the right track 👍🏼 (especially for the public surface) so a PR would most certainly be welcome.

…one of the locations there was a TODO saying nulls would be disallowed in the next major release.

I opened issue #802 to track one of those earlier. Is that the one? Did you comes across others?

I don't want to change public APIs to nullable if the intent is that null support is going to be dropped.

Thanks for checking first!

By the way, in PR #804 for Pad, I extended the tests to reference types and enabled nullable context. I am not very happy with the test duplication for sake of testing nullability at compilation time, but I haven't spent much time think about how to validate it otherwise. It seems it needs another class of tests with explicitly declared types (instead of using var). If you have any ideas or if you've across something similar in other projects then fire away!

[sid-6581]

#802 was the one I was thinking of, yes. I haven't come across any others like that yet, but I'm going through things one at a time.

I've submitted a couple of PRs that I think will improve things. There's still more PRs to come, but we'll get there! For the most part things look good as far as I can tell.

I'll also check out the Pad tests to see, I haven't had a chance to look at that yet.

[Arithmomaniac]

CI builds are published at: https://www.myget.org/F/morelinq/api/v3/index.json

Any chance we could get one of them published as a beta? There's two years of bug fixes waiting. (To be fair, there aren't a lot of bugs - kudos.)

[atifaziz]

I'll see if I can push out a beta in the coming days.

[frozenprakash]

Damn MoreLinq is seriously undermined!
I watched every single video on YouTube too and started using MoreLinq way too vastly in all my projects!!

Really awesome work!

[atifaziz]

Life happens and so the latest release took a back seat for too long, but for what it's worth, 3.4 is now released! Thank you for your understanding.