Give option to bind hotkey for switching window mode

[makedir]

The default ESC bind is contra-productive, because it is overwritten by most games. You just can switch to window mode while the connecting... window happens. If you are in the game, it doesnt work anymore, and closes the game if pressed ESC (most games close by this).

• give option for hotkey this
• give option to NOT start default into fullscreen mode

[jorys-paulin]

@makedir

• What keybinding should be used then?
• It should be possible

[makedir]

@jorys-paulin Anything other than ESC and something which is not used anywhere or with high chance not used. ESC closes most games, or opens the game menu. Best would be alt+enter, because it is the default binding for switching window/fullscreen, at least under Windows.

[jorys-paulin]

@makedir On Windows 10, I tried Atl+Enter with no success, however F11 worked fine. It is also the shortcut for ChromeOS, platform for which moonlight-chrome was initially started

[makedir]

@jorys-paulin No. alt+enter is the correct normal Window binding to switch between windowed and fullscreen applications, mostly since Windows NT.

https://support.microsoft.com/en-us/help/81823/alt-enter-switches-between-window-and-full-screen

It wont work for Chrome mostly, because Chrome has no (normal) fullscreen mode. It mostly just works for (whatever) applications, like games.

Please dont change it to any single binding like F11. Something like ant+F11 maybe, but better give option to make it changeable for the user.

[jorys-paulin]

@makedir Well windows explorer does nothing when Alt+Enter, but does fullscreen with F11, but I get your point.

[makedir]

@jorys-paulin Well, I would be fine with a change to F11 for now, until a user change would be implemented. Anything other than ESC like F11 would be ok.

[jorys-paulin]

@makedir I made a quick & dirty build of your feature request, you can only change fullscreen or windowed at startup for now.
moonlight-chrome.zip

[makedir]

@jorys-paulin but that wouldnt help much. I need to toggle fullscreen/window a lot like every few minutes. Can you please make another dirty build of changing ESC to F11, that would help a lot. Or wont that work after the game started? Is the keybinding intercepted on the client first?

[jorys-paulin]

@makedir I don't really know since the cursor (and so the keyboard) is captured by the C++ module, I don't know if I'll be able to capture it using javascript.

[makedir]

@jorys-paulin but where does the esc binding come from? didnt you implement it? same with when clicking on the maximize button, it goes into fullscreen instead of maximizing the window.

[jorys-paulin]

@makedir It's all handled by chrome

[makedir]

@jorys-paulin If I click on maximize on another app like Google Keep it does not go into fullscreen, so that is a behavior of your app.

[jorys-paulin]

@makedir My fault, it is made so here

[jorys-paulin]

@makedir I think I resolved your issue with this pull request (#435), let me know what you think!

[makedir]

@jorys-paulin where? I don't see any builds but one from march 28th.

[jorys-paulin]

@makedir It has to be accepted (marked merged) to be in the official builds

[makedir]

@jorys-paulin and how would I test it then? I don't see any test build download links on the site.

[jorys-paulin]

@makedir Let me make you a build, I'll be back in a minute

[jorys-paulin]

@makedir Sorry, it is taking sooo long to upload...

[jorys-paulin]

@makedir Here's a build. Please note that I wasn't able to add a hotkey :/
window-mode.zip

[makedir]

And that means what? What is changed then?

[jorys-paulin]

That means you can't change screen size at runtime but before you launch a game. It's mostly a hack, but I don't know how to make it work at runtime unfortunately...

[jorys-paulin]

@makedir So, is it a build you'll accept? What should I change?

[elegos]

You can actually switch from full-screen to windowed when you connect to a game and immediately, before clicking anywhere in the window, pressing the [ESC] key.

1. enter Moonlight
2. choose your game
3. press [ESC]
4. click in the window to let it gain mouse/keyboard inputs

P.S.
Tested on Linux using GNOME 3.28.2.

[makedir]

@elegos I said that before up there. This is redundant, because I want to switch in game back and forth from Window to full-screen and this doesnt work so far.