Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build scripts should also run on Un*x operating systems #31

Open
moodmosaic opened this issue Jan 19, 2018 · 9 comments
Open

Build scripts should also run on Un*x operating systems #31

moodmosaic opened this issue Jan 19, 2018 · 9 comments

Comments

@moodmosaic
Copy link
Owner

moodmosaic commented Jan 19, 2018

because right now I'm mostly on macOS High Sierra (10.13) and Ubuntu (16.04) and I can't easily run a build and push a new package on NuGet Gallery. #30, #21

@moodmosaic moodmosaic changed the title Build scripts should also run in Un*x operating systems Build scripts should also run on Un*x operating systems Jan 19, 2018
@zvirja
Copy link
Contributor

zvirja commented Jan 19, 2018

@moodmosaic Unfortunately, I don't have MacBook yet to test up the script there. That's why you need AppVeyor to run the build 😄

Do you want me to provide you with the latest artifacts (build locally) so you could proceed with the release? 😅

@moodmosaic
Copy link
Owner Author

Do you want me to provide you with the latest artifacts (build locally) so you could proceed with the release? 😅

Sure 😆 I may not try them right now but I'm curious so I think I'll get to them soon. Thank you!

@zvirja
Copy link
Contributor

zvirja commented Jan 20, 2018

@moodmosaic It seems that you performed some weird tagging, so now git describe is confused:

$ git describe --tags --long --abbrev=40 --first-parent --match=v*
warning: tag 'v1.0.5' is really 'v1.1.0' here
v1.0.5-0-ge10a97a90b3858ef08bd0b644976bfd3379ca3ad

It's showing v1.0.5 instead of v1.1.0. I found that it could happen if you based tag on other tag: https://stackoverflow.com/questions/14380053/renaming-git-tags-results-in-inconsistency.

Could you please fix the tags (probably, remove and push again), so that git describe command shows 1.1.0 instead?

Thanks 😉

@moodmosaic
Copy link
Owner Author

Yes, I did that (on the Stack Overflow answer).

I'll just delete that tag and re-tag it, in the next couple of hours hopefully.

Thank you for pointing this out.

@zvirja
Copy link
Contributor

zvirja commented Jan 20, 2018

@moodmosaic Thanks! Let me know when you are ready. After that I'll trigger the build and attach the artifacts, so you could publish them 😉

@zvirja
Copy link
Contributor

zvirja commented Jan 20, 2018

Just realized that actually I don't need to wait till you fix the tag to produce the build with valid version. Therefore, here the v1.1.0 release is: v1.1.0 Release artifacts.zip

@moodmosaic
Copy link
Owner Author

Tags should be all set now. I will push a new version on NuGet tomorrow.

@moodmosaic
Copy link
Owner Author

FWIW, I've just pushed Fare 1.1.0 on NuGet.

@zvirja
Copy link
Contributor

zvirja commented Jan 22, 2018

@moodmosaic Awesome, thanks for notifying! 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants