Skip to content

fix: mustache: allow certain non body level elements as root in linter #344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: mustache: allow certain non body level elements as root in linter #344

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 28 additions & 0 deletions mustache_lint/mustache_lint.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,11 +233,39 @@ function print_message($severity, $mesage) {
echo "$FILENAME - $severity: $mesage\n";
}

/**
* If the template content has a top‐level tag that needs a container,
* wrap it in the appropriate parent before validation.
*
* @param string $content Raw HTML snippet from Mustache render.
* @return string The potentially wrapped snippet.
*/
function wrap_disallowed_root_elements($content) {
// Map of tag → [open wrapper, close wrapper].
$wrappers = [
'li' => ['<ul>', '</ul>'],
'tr' => ['<table>', '</table>'],
'td' => ['<table><tr>', '</tr></table>'],
];

$trimmed = ltrim($content);
foreach ($wrappers as $tag => list($open, $close)) {
// If the very first tag is this one, wrap it.
if (stripos($trimmed, "<{$tag}") === 0) {
return $open . "\n" . $content . "\n" . $close;
}
}

return $content;
}

/**
* Wrap the template content in a html5 wrapper and validate it
*/
function check_html_validation($content) {
if (strpos($content, '<head>') === false) {
// Wrap lone <li>, <tr>, etc., into valid wrappers.
$content = wrap_disallowed_root_elements($content);
// Primative detection if we have full html body, if not, wrap it.
// (This isn't bulletproof, obviously).
$wrappedcontent = "<!DOCTYPE html><html lang=\"en\"><head><title>Validate</title></head><body>\n{$content}\n</body></html>";
Expand Down