You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
here's a little test repo, I did the initial install via the REPL, and files in the base repo & the sub-module are both pulled correctly & print a version message:
submodule version: 1
base repo version: 1
after install, I pushed commits to both repos to have them print twos, then hit the update button for the script in the project manager, confirming that only the base repo pulled the new commits, submodule remained unchanged:
submodule version: 1
base repo version: 2
deleting & reinstalling the project got em both up to date:
submodule version: 2
base repo version: 2
previously, I was just distributing each version of my submodule'd scripts in .zip files as a workaround, but that caused some weirdness with the new norns.community, so @tehn proposed fixing the root cause here
tysm for taking a look ! hopefully there's not something obvious I'm missing. since submodules are more of an opt-in feature of git I didn't necessarily expect submodule pulls to be a feature but it certainly would be helpful!
The text was updated successfully, but these errors were encountered:
submodules are not uncommon, but on the other hand: deleting and reinstalling is not such an onerous workaround, is it? we are just talking about a few KB of lua files here.
anyways, what we would really like is to issue the go-git equivalent of git submodule update --init --recursive. right?
i do not personally understand the go-git model (or go for that matter) well enough to know how to get a list of therse Submodule objects out of the git worktree object. it seems doable: not as convenient as adding options to the w.Pull() invocation here, but likely not all that difficult to add either...
here's a little test repo, I did the initial install via the REPL, and files in the base repo & the sub-module are both pulled correctly & print a version message:
after install, I pushed commits to both repos to have them print twos, then hit the update button for the script in the project manager, confirming that only the base repo pulled the new commits, submodule remained unchanged:
deleting & reinstalling the project got em both up to date:
previously, I was just distributing each version of my submodule'd scripts in .zip files as a workaround, but that caused some weirdness with the new norns.community, so @tehn proposed fixing the root cause here
tysm for taking a look ! hopefully there's not something obvious I'm missing. since submodules are more of an opt-in feature of git I didn't necessarily expect submodule pulls to be a feature but it certainly would be helpful!
The text was updated successfully, but these errors were encountered: