-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve REPL console appearance in small/resized browser windows #168
Comments
I agree on both points. Bottom relative positioning for the REPL would be better - there was some random hang up I ran into originally but it escapes me now. Wrapping long lines is also okay, bonus points for making it a configurable setting. I’d totally love to see these changes. |
Fixes first part of monome#168
Great! I added a PR for the first one. The thing I want to think about w/r/t config is that currently all the config settings are handed straight over to the Editor component in the Is it worth changing the config data structure (and therefore file format) in order to separate out editor- and REPL-related settings? Maybe not at this point... but it also looks like the Editor component itself gets & stores settings from the session in addition to props, which complicates things, unless I’m misreading. I’ll look into it more tomorrow or Wednesday. |
(actually, I doubt I'll get much more done this week -- I'm traveling for work and I thought I'd copied my maiden files over to my laptop from my Pi, but it seems like not everything made it over. Next week, then...) |
Fixes second part of monome#168
A couple window-size-related UX issues have been bugging me lately:
I'll try to take these on over the weekend or the next few days.
I use Firefox on Mac OS Mojave 10.14.6, but both of these seem to apply to Safari & Chrome as well.
The text was updated successfully, but these errors were encountered: