-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Detached with relay control #1011
base: master
Are you sure you want to change the base?
Detached with relay control #1011
Conversation
just a suggestion but to have a new button type called "DetachedWithRelay" is not the way to go, as the button is no longer detached, maybe you could simply add a check box to "Momentary" button type options to add extra HomeKit button options, maybe call the check box "Advanced button options" or "HomeKit Buttons" |
Hi Andy, completely agree. Let me try to do it. |
Hi, i've just pushed a new version with the HomeKit button option. I'm now stuck on one question, which i think its important to make this clean. I'm using stateless switch, but it has its own input inverted, hap type, etc. i think i should create and HomeKit button class, and synchornize the options with the momentary switch, what do you think? its the best way to go? |
Sorry for long delay in replying, ye sounds good to me, @rojer what do you think? |
Hi Guys, |
Hi, |
I totally expected this to already be in the firmware when I started using it. @timoschilling do you think it could be merged? Do you need any kind of help with it? |
Interesting feature. I hope it will be merged. |
@markirb any chance to include this functionality? should i follow this last approach and merge the code? |
Yes. Can you please resolve conflicts with a rebase? I will review then |
I've tried to do a initial effort for targeting #147, specially on having the single click controlling the relay without relying on HomeKit.
I've created a new input mode, detached with relay control, and i tied the single click to the relay.
I've tried to make it very clean, and maybe there are some limitation, but i've tested in 1PM and 2.5 and its working as expected.