Handle exceptions properly

Author: viveksinghggits

scripts/release/build/image_build_process.py

@@ -122,8 +122,7 @@ def pull_image(self, image):
         try:
             docker_cmd.image.pull(image, quiet=True)
         except Exception as e:
-            logger.error(f"Failed pulling image. {e}")
-            raise e
+            raise Exception("Failed pulling image.") from e
 
     def get_manfiest_list_digest(self, image) -> Optional[str]:
         self.pull_image(image)
@@ -133,8 +132,7 @@ def get_manfiest_list_digest(self, image) -> Optional[str]:
             manifest = docker_cmd.image.inspect(image)
             return manifest.id
         except Exception as e:
-            logger.error(f"Failed inspecting the image to get manifest list digest. {e}")
-            raise e
+            raise Exception("Failed inspecting the image to get manifest list digest") from e
 
     def build_image(self, tags: list[str],
                     dockerfile: str,

scripts/release/kubectl_mongodb/promote_kubectl_plugin.py

@@ -62,7 +62,10 @@ def main():
 
     if os.environ.get("SKIP_GITHUB_RELEASE_UPLOAD", "false").lower() == "false":
         github_artifacts = artifacts_tar + [checksum_file]
-        upload_assets_to_github_release(github_artifacts, release_version)
+        try:
+            upload_assets_to_github_release(github_artifacts, release_version)
+        except Exception as e:
+            raise e
 
 
 # get_commit_from_tag gets the commit associated with a release tag, so that we can use that

scripts/release/kubectl_mongodb/utils.py

@@ -46,15 +46,13 @@ def s3_path(filename: str, version: str) -> str:
 # the GitHub release as assets.
 def upload_assets_to_github_release(asset_paths: list[str], release_version: str):
     if not GITHUB_TOKEN:
-        logger.info("ERROR: GITHUB_TOKEN environment variable not set.")
-        sys.exit(1)
+        raise Exception("ERROR: GITHUB_TOKEN environment variable not set.")
 
     try:
         g = Github(GITHUB_TOKEN)
         repo = g.get_repo(GITHUB_REPO)
     except GithubException as e:
-        logger.info(f"ERROR: Could not connect to GitHub or find repository '{GITHUB_REPO}', Error {e}.")
-        sys.exit(1)
+        raise Exception(f"ERROR: Could not connect to GitHub or find repository {GITHUB_REPO}") from e
 
     try:
         gh_release = None
@@ -65,22 +63,18 @@ def upload_assets_to_github_release(asset_paths: list[str], release_version: str
                 break
 
         if gh_release is None:
-            logger.error(
+            raise Exception(
                 f"Could not find release (published or draft) with tag '{release_version}'. Please ensure the release exists."
             )
-            sys.exit(2)
     except GithubException as e:
-        logger.debug(f"Failed to retrieve releases from the repository {GITHUB_REPO}. Error: {e}")
-        sys.exit(2)
+        raise Exception(f"Failed to retrieve releases from the repository {GITHUB_REPO}") from e
 
     for asset_path in asset_paths:
         asset_name = os.path.basename(asset_path)
         logger.info(f"Uploading artifact '{asset_name}' to github release as asset")
         try:
             gh_release.upload_asset(path=asset_path, name=asset_name, content_type="application/gzip")
         except GithubException as e:
-            logger.debug(f"ERROR: Failed to upload asset {asset_name}. Error: {e}")
-            sys.exit(2)
+            raise Exception(f"ERROR: Failed to upload asset {asset_name}") from e
         except Exception as e:
-            logger.debug(f"An unexpected error occurred during upload of {asset_name}: {e}")
-            sys.exit(2)
+            raise Exception(f"An unexpected error occurred during upload of {asset_name}") from e

scripts/release/release_info.py

@@ -198,5 +198,7 @@ def manifest_list_digest_for_image(image: str) -> str:
     if release_info_filename is not None:
         with open(release_info_filename, "w") as file:
             file.write(release_info)
-
-    upload_assets_to_github_release([release_info_filename], args.version)
+    try:
+        upload_assets_to_github_release([release_info_filename], args.version)
+    except Exception as e:
+        raise e