Commit 666cdf3
authored
Fix chart linting issue in
# Summary
The helm chart linting functionality is added as part on `lint_repo`
task eventually called our precommit script. Apart from the lint_repo
task, precommit script also gets called from the evg task
`evg/run_pre_commit`. And when it's run via `evg/run_pre_commit` it's
failing, because `ct` is not found. We forgot to update the
`evg/run_pre_commit` task to setup `ct` because it's doesn't get run in
PR patches.
Since this task (`evg/run_pre_commit`) doesn't get executed as part of
PR patches, we didn't face this problem in PR patches. But we got to
know about it from [a
PR](#468) that
dependabot raises.
In PR patches the task `evg/run_pre_commit` gets run but the precommit
script doesn't actually get executed because it's requires the branch
name to be in [specific
format](https://github.com/mongodb/mongodb-kubernetes/blob/master/scripts/evergreen/precommit_bump.sh#L18).
## Proof of Work
Successful CI in this PR.
- Make sure lint_repo passes
- Make sure run_pre_commit passes and it actually calls precommit,
because this PR branch is named in the format `_version_bump`, that is
expected by `run_pre_commit`.
https://github.com/mongodb/mongodb-kubernetes/blob/master/scripts/evergreen/precommit_bump.sh#L18
## Checklist
- [ ] Have you linked a jira ticket and/or is the ticket in the title?
- [x] Have you checked whether your jira ticket required DOCSP changes?
- [x] Have you added changelog file?
- use `skip-changelog` label if not needed
- refer to [Changelog files and Release
Notes](https://github.com/mongodb/mongodb-kubernetes/blob/master/CONTRIBUTING.md#changelog-files-and-release-notes)
section in CONTRIBUTING.md for more detailsevg/run_pre_commit task (#470)1 parent be29e59 commit 666cdf3
2 files changed
+11
-7
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
242 | 242 | | |
243 | 243 | | |
244 | 244 | | |
| 245 | + | |
| 246 | + | |
| 247 | + | |
| 248 | + | |
| 249 | + | |
| 250 | + | |
| 251 | + | |
| 252 | + | |
| 253 | + | |
245 | 254 | | |
246 | 255 | | |
247 | 256 | | |
| |||
250 | 259 | | |
251 | 260 | | |
252 | 261 | | |
253 | | - | |
254 | | - | |
255 | | - | |
256 | | - | |
257 | | - | |
258 | | - | |
259 | | - | |
| 262 | + | |
260 | 263 | | |
261 | 264 | | |
262 | 265 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
311 | 311 | | |
312 | 312 | | |
313 | 313 | | |
| 314 | + | |
314 | 315 | | |
315 | 316 | | |
316 | 317 | | |
| |||
0 commit comments