Add missing conflicts #226
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmoody256
force-pushed
the
conflict_fix
branch
from
82c493c to
d8565ce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds conflicts for most of the packages to help create saner environments. The problem is that all the versions need to symlink their binaries to the the same location, which means there is an actual conflict. Labeling the conflict in the formulae makes homebrew print the correct advice to unlink conflicting packages before trying to install a new version.
Otherwise it will just print more ambiguous error messages that the current package could not complete the symlink because the symlink already exists (although it is pointing to a different existing installed versions). Some of the packages use keg_only to deal with this, but that creates ambiguity around what version is being used, as the service only runs the one linked, not the keg_only ones.
This change also removes the EOL 4.4 versions.