Rename method.

Author: WaVEV

django_mongodb_backend/expressions/builtins.py

@@ -30,11 +30,7 @@
 
 
 def base_expression(self, compiler, connection, as_path=False, **extra):
-    if (
-        as_path
-        and hasattr(self, "as_mql_path")
-        and getattr(self, "is_simple_expression", lambda: False)()
-    ):
+    if as_path and hasattr(self, "as_mql_path") and getattr(self, "can_use_path", False):
         return self.as_mql_path(compiler, connection, **extra)
 
     expr = self.as_mql_expr(compiler, connection, **extra)

django_mongodb_backend/fields/array.py

@@ -381,7 +381,8 @@ def __init__(self, index, base_field, *args, **kwargs):
         self.index = index
         self.base_field = base_field
 
-    def is_simple_expression(self):
+    @property
+    def can_use_path(self):
         return self.is_simple_column
 
     @property

django_mongodb_backend/fields/embedded_model.py

@@ -166,7 +166,8 @@ def __init__(self, key_name, ref_field, *args, **kwargs):
     def get_lookup(self, name):
         return self.ref_field.get_lookup(name)
 
-    def is_simple_expression(self):
+    @property
+    def can_use_path(self):
         return self.is_simple_column
 
     @cached_property

django_mongodb_backend/fields/embedded_model_array.py

@@ -248,7 +248,8 @@ def __call__(self, this, *args, **kwargs):
         self._lhs = self._sub_transform(self._lhs, *args, **kwargs)
         return self
 
-    def is_simple_expression(self):
+    @property
+    def can_use_path(self):
         return self.is_simple_column
 
     @cached_property

django_mongodb_backend/fields/json.py

@@ -72,6 +72,7 @@ def _has_key_predicate(path, root_column=None, negated=False, as_path=False):
     return result
 
 
+@property
 def has_key_check_simple_expression(self):
     rhs = [self.rhs] if not isinstance(self.rhs, (list, tuple)) else self.rhs
     return self.is_simple_column and all(key.isalnum() for key in rhs)
@@ -147,7 +148,7 @@ def key_transform_in(self, compiler, connection, as_path=False):
     Return MQL to check if a JSON path exists and that its values are in the
     set of specified values (rhs).
     """
-    if as_path and self.is_simple_expression():
+    if as_path and self.can_use_path():
         return builtin_lookup_path(self, compiler, connection)
 
     lhs_mql = process_lhs(self, compiler, connection)
@@ -226,6 +227,7 @@ def key_transform_numeric_lookup_mixin_path(self, compiler, connection):
     return builtin_lookup_path(self, compiler, connection)
 
 
+@property
 def keytransform_is_simple_column(self):
     previous = self
     while isinstance(previous, KeyTransform):
@@ -242,11 +244,11 @@ def register_json_field():
     HasKey.mongo_operator = None
     HasKeyLookup.as_mql_path = partialmethod(has_key_lookup, as_path=True)
     HasKeyLookup.as_mql_expr = partialmethod(has_key_lookup, as_path=False)
-    HasKeyLookup.is_simple_expression = has_key_check_simple_expression
+    HasKeyLookup.can_use_path = has_key_check_simple_expression
     HasKeys.mongo_operator = "$and"
     JSONExact.process_rhs = json_exact_process_rhs
-    KeyTransform.is_simple_column = property(keytransform_is_simple_column)
-    KeyTransform.is_simple_expression = keytransform_is_simple_column
+    KeyTransform.is_simple_column = keytransform_is_simple_column
+    KeyTransform.can_use_path = keytransform_is_simple_column
     KeyTransform.as_mql_path = partialmethod(key_transform, as_path=True)
     KeyTransform.as_mql_expr = partialmethod(key_transform, as_path=False)
     KeyTransformExact.as_mql_expr = key_transform_exact_expr

django_mongodb_backend/functions.py

@@ -292,10 +292,6 @@ def trunc_time(self, compiler, connection):
     }
 
 
-def is_simple_expression(self):  # noqa: ARG001
-    return False
-
-
 def register_functions():
     Cast.as_mql_expr = cast
     Concat.as_mql_expr = concat
@@ -323,4 +319,4 @@ def register_functions():
     TruncDate.as_mql_expr = trunc_date
     TruncTime.as_mql_expr = trunc_time
     Upper.as_mql_expr = preserve_null("toUpper")
-    Func.is_simple_expression = is_simple_expression
+    Func.can_use_path = False

django_mongodb_backend/lookups.py

@@ -138,14 +138,15 @@ def uuid_text_mixin(self, compiler, connection):  # noqa: ARG001
     raise NotSupportedError("Pattern lookups on UUIDField are not supported.")
 
 
-def is_simple_expression(self):
+@property
+def can_use_path(self):
     simple_column = getattr(self.lhs, "is_simple_column", False)
     constant_value = is_constant_value(self.rhs)
     return simple_column and constant_value
 
 
 def register_lookups():
-    Lookup.is_simple_expression = is_simple_expression
+    Lookup.can_use_path = can_use_path
     BuiltinLookup.as_mql_path = builtin_lookup_path
     BuiltinLookup.as_mql_expr = builtin_lookup_expr
     FieldGetDbPrepValueIterableMixin.resolve_expression_parameter = (