From 8c24e8b47afb8118aac01d1aa63282f5f9ef6528 Mon Sep 17 00:00:00 2001 From: Jib Date: Thu, 25 Sep 2025 14:04:35 -0400 Subject: [PATCH 1/3] PYTHON-5582: Create pull request template MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit [PYTHON-5582](https://jira.mongodb.org/browse/PYTHON-5582) ## Summary Adds a Pull Request template to this repository based on our new dbx-python code review policy. ## Changes in this PR * PULL_REQUEST_TEMPLATE.md ## Test Plan Make a PR from this branch to confirm ### Screenshots (optional) ## Checklist ### Checklist for Author - [x] Did you update the changelog (if necessary)? **Not necessary** - [x] Is the intention of the code captured in relevant tests? **Not necessary** - [x] If there are new TODOs, has a related JIRA ticket been created? **Not necessary** ### Checklist for Reviewer [@sleepyStick , @caseyclements ] - [ ] Does the title of the PR reference a JIRA Ticket? - [ ] Do you fully understand the implementation? (Would you be comfortable explaining how this code works to someone else?) - [ ] Have you checked for spelling & grammar errors? - [ ] Is all relevant documentation (README or docstring) updated? ## Focus Areas for Reviewer For reviewers provide suggestions on what should be changed about the checklist to better cater to this repository. --- .github/PULL_REQUEST_TEMPLATE.md | 50 ++++++++++++++++++++++++++++++++ 1 file changed, 50 insertions(+) create mode 100644 .github/PULL_REQUEST_TEMPLATE.md diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md new file mode 100644 index 00000000..b058198f --- /dev/null +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -0,0 +1,50 @@ +[Issue Key](https://jira.mongodb.org/browse/{ISSUE_KEY}) + + +## Summary + +## Changes in this PR + + + + + +## Test Plan + + + + + +### Screenshots (optional) + + + + + +## Checklist + + + + + +### Checklist for Author + + +- [ ] Did you update the changelog (if necessary)? +- [ ] Is the intention of the code captured in relevant tests? +- [ ] If there are new TODOs, has a related JIRA ticket been created? + + +### Checklist for Reviewer {@primary_reviewer} + + +- [ ] Does the title of the PR reference a JIRA Ticket? +- [ ] Do you fully understand the implementation? (Would you be comfortable explaining how this code works to someone else?) +- [ ] Have you checked for spelling & grammar errors? +- [ ] Is all relevant documentation (README or docstring) updated? + + +## Focus Areas for Reviewer + + + From 2e221db4d50f5caaa12e84a1a068d280a15fd8f2 Mon Sep 17 00:00:00 2001 From: jib Date: Mon, 29 Sep 2025 12:23:04 -0400 Subject: [PATCH 2/3] lint fixes --- .github/PULL_REQUEST_TEMPLATE.md | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index b058198f..aa0a2365 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -30,17 +30,17 @@ ### Checklist for Author -- [ ] Did you update the changelog (if necessary)? -- [ ] Is the intention of the code captured in relevant tests? +- [ ] Did you update the changelog (if necessary)? +- [ ] Is the intention of the code captured in relevant tests? - [ ] If there are new TODOs, has a related JIRA ticket been created? ### Checklist for Reviewer {@primary_reviewer} -- [ ] Does the title of the PR reference a JIRA Ticket? -- [ ] Do you fully understand the implementation? (Would you be comfortable explaining how this code works to someone else?) -- [ ] Have you checked for spelling & grammar errors? +- [ ] Does the title of the PR reference a JIRA Ticket? +- [ ] Do you fully understand the implementation? (Would you be comfortable explaining how this code works to someone else?) +- [ ] Have you checked for spelling & grammar errors? - [ ] Is all relevant documentation (README or docstring) updated? From 5d708a2925612ba872fc8ae44d54fece0f6250b5 Mon Sep 17 00:00:00 2001 From: Jib Date: Fri, 3 Oct 2025 11:57:40 -0400 Subject: [PATCH 3/3] Fix spacing --- .github/PULL_REQUEST_TEMPLATE.md | 16 ++-------------- 1 file changed, 2 insertions(+), 14 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index aa0a2365..e4516e40 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -1,50 +1,38 @@ [Issue Key](https://jira.mongodb.org/browse/{ISSUE_KEY}) - ## Summary + -## Changes in this PR +## Changes in this PR - ## Test Plan - - ### Screenshots (optional) - - ## Checklist - - ### Checklist for Author - - [ ] Did you update the changelog (if necessary)? - [ ] Is the intention of the code captured in relevant tests? - [ ] If there are new TODOs, has a related JIRA ticket been created? - ### Checklist for Reviewer {@primary_reviewer} - - [ ] Does the title of the PR reference a JIRA Ticket? - [ ] Do you fully understand the implementation? (Would you be comfortable explaining how this code works to someone else?) - [ ] Have you checked for spelling & grammar errors? - [ ] Is all relevant documentation (README or docstring) updated? - ## Focus Areas for Reviewer -