feat(NODE-6507): generate encryption configuration on mongoose connect #6
+2,387
−182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baileympearson
force-pushed
the
NODE-6507-generate-schema-maps
branch
from
411e69d to
ebe3d06
Compare
baileympearson
changed the title
Co-authored-by: Aditi Khare <[email protected]>
Co-authored-by: Aditi Khare <[email protected]>
baileympearson
force-pushed
the
NODE-6507-generate-schema-maps
branch
from
ebe703a to
be4563e
Compare
baileympearson
changed the base branch from
master
to
NODE-6506-add-support-for-encrypted-schemas
vkarpov15
reviewed
Jan 30, 2025
| @@ -1083,7 +1083,7 @@ Connection.prototype.on = function on(event, callback) { | |||
| // to avoid uncaught exceptions when using `on('error')`. See gh-14377. | |||
| Connection.prototype.once = function on(event, callback) { | |||
| if (event === 'error' && this.$initialConnection) { | |||
| this.$initialConnection.catch(() => {}); | |||
| this.$initialConnection.catch(() => { }); | |||
There was a problem hiding this comment.
Please avoid making these sort of minor style changes, they make review difficult and may cause linter issues
baileympearson
force-pushed
the
NODE-6506-add-support-for-encrypted-schemas
branch
2 times, most recently
from
9099d21 to
3fbefcc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Automatically generate encryptedFieldMaps and schemaMaps when connecting a Mongoose connection that has schemas configured for CSFLE or QE.
Includes changes from #5 and Automattic#15139.
Examples
See encryption.test.ts in the PR for integration test examples.