fix(eslint): update eslint plugins to latest and resolve all new issues #7596
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gribnoysup
changed the title
addaleax
reviewed
Nov 25, 2025
| import type { FetchStatus } from '../utils/fetch-status'; | ||
|
|
||
| import { FetchReasons } from '../utils/fetch-reason'; | ||
| import type { FetchReason } from '../utils/fetch-reason'; |
Collaborator
There was a problem hiding this comment.
Would be nice if we could go the other route and remove the enums, is that an option here?
Collaborator
Author
There was a problem hiding this comment.
I was looking at these newly triggered errors and had the same thought, but I think it would be too big of a change just for a valuable otherwise eslint deps version update to be honest... I'm on board for finding a way to move away from them. Maybe we can prohibit the syntax right away and make exception for existing ones, then slowly start removing them? Something like this sounds reasonable?
gribnoysup
force-pushed
the
update-eslint-to-latest-and-resolve-new-warnings
branch
4 times, most recently
from
4e1ec38 to
2e61807
Compare
gribnoysup
force-pushed
the
update-eslint-to-latest-and-resolve-new-warnings
branch
from
2e61807 to
71cf178
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not intended for review, opening just to kick off CI and track the progress on this work. I'm going to split it ino smaller chunks that should be easier to review and merge