fix(eslint): resolve react-hooks/static-components issues (#7611)

fix(eslint): resolve react-hooks/statis-components issues

Author: gribnoysup

configs/eslint-config-compass/index.js

@@ -9,7 +9,6 @@ const chaiFriendly = require('eslint-plugin-chai-friendly');
 const tempNewEslintRulesDisabled = {
   'react-hooks/refs': 'off',
   'react-hooks/preserve-manual-memoization': 'off',
-  'react-hooks/static-components': 'off',
   '@typescript-eslint/no-unsafe-enum-comparison': 'off',
 };
 

packages/compass-assistant/src/compass-assistant-provider.spec.tsx

@@ -88,6 +88,8 @@ const TestComponent: React.FunctionComponent<{
 
   return (
     <DrawerContentProvider>
+      {/* Breaking this rule is fine while none of the tests try to re-render the content */}
+      {/* eslint-disable-next-line react-hooks/static-components */}
       <MockedProvider
         originForPrompt="mongodb-compass"
         appNameForPrompt="MongoDB Compass"
@@ -113,6 +115,8 @@ describe('useAssistantActions', function () {
 
       return (
         <DrawerContentProvider>
+          {/* Breaking this rule is fine while none of the tests try to re-render the content */}
+          {/* eslint-disable-next-line react-hooks/static-components */}
           <MockedProvider
             originForPrompt="mongodb-compass"
             appNameForPrompt="MongoDB Compass"

packages/compass-collection/src/components/collection-tab.tsx

@@ -331,6 +331,8 @@ const CollectionTab = ({
   };
 
   return (
+    // This component is not created in render, just accessed from context
+    // eslint-disable-next-line react-hooks/static-components
     <QueryBarPlugin {...pluginProps}>
       <CollectionTabWithMetadata
         collectionMetadata={collectionMetadata}

packages/compass-query-bar/src/index.tsx

@@ -67,6 +67,8 @@ export const QueryBar: React.FunctionComponent<
   React.ComponentProps<typeof QueryBarComponent>
 > = (props) => {
   const Component = useQueryBarComponent();
+  // Component is not created, just accessed via context
+  // eslint-disable-next-line react-hooks/static-components
   return <Component {...props}></Component>;
 };