fix(eslint): resolve no-redundant-type-constituents issues (#7608)

Author: gribnoysup

configs/eslint-config-compass/index.js

@@ -11,7 +11,6 @@ const tempNewEslintRulesDisabled = {
   'react-hooks/set-state-in-effect': 'off',
   'react-hooks/preserve-manual-memoization': 'off',
   'react-hooks/static-components': 'off',
-  '@typescript-eslint/no-redundant-type-constituents': 'off',
   '@typescript-eslint/no-unsafe-enum-comparison': 'off',
 };
 

packages/compass-aggregations/src/modules/pipeline-builder/builder-helpers.ts

@@ -63,7 +63,7 @@ export function getPipelineStageOperatorsFromBuilderState(
 export function getPipelineStageOperatorsFromBuilderState(
   state: RootState,
   filterEmptyStageOperators = true
-): (string | null)[] | string[] {
+): (string | null)[] {
   const stages =
     state.pipelineBuilder.pipelineMode === 'builder-ui'
       ? state.pipelineBuilder.stageEditor.stages

packages/compass-components/src/hooks/use-scrollbars.tsx

@@ -118,7 +118,7 @@ interface WithPortalClassName {
 export const withPortalScrollbars = <
   ComponentProps extends WithPortalClassName
 >(
-  WrappedComponent: React.ComponentType<ComponentProps & WithPortalClassName>
+  WrappedComponent: React.ComponentType<ComponentProps>
 ) => {
   const ComponentWithScrollbars = (props: ComponentProps) => {
     const { className } = useScrollbars();

packages/compass-components/src/hooks/use-theme.tsx

@@ -42,13 +42,11 @@ export const ThemeProvider = ({
 const withDarkMode = function <
   ComponentProps extends WithDarkModeProps = WithDarkModeProps
 >(
-  WrappedComponent: React.ComponentType<ComponentProps & WithDarkModeProps>
+  WrappedComponent: React.ComponentType<ComponentProps>
 ): React.ComponentType<ComponentProps> {
   const ComponentWithDarkMode = (
     props: ComponentProps,
-    ref: React.ForwardedRef<
-      React.ComponentType<ComponentProps & WithDarkModeProps>
-    >
+    ref: React.ForwardedRef<React.ComponentType<ComponentProps>>
   ) => {
     const darkMode = useDarkMode();
     return (

packages/compass-e2e-tests/helpers/commands/resize-window.ts

@@ -14,7 +14,7 @@ export async function resizeWindow(
   height: number,
   dangerouslySkipWaitFor?: boolean
 ): Promise<WindowSize> {
-  let newSize: WindowSize | undefined | void;
+  let newSize: WindowSize | undefined;
   // On macOS you can only change height as much as the system allows, so when
   // on macOS, skip checking for the height matching what we requested. That's
   // not great that we can't be sure that we got what we requested, but there's

packages/compass-preferences-model/src/preferences-schema.tsx

@@ -172,8 +172,7 @@ export type AtlasOrgPreferences = {
 
 export type AllPreferences = UserPreferences &
   CliOnlyPreferences &
-  NonUserPreferences &
-  PermanentFeatureFlags;
+  NonUserPreferences;
 
 // Types related to PreferenceDefinition
 type PostProcessFunction<T> = (

packages/compass-query-bar/src/components/option-editor.tsx

@@ -38,8 +38,9 @@ import type {
 } from '@mongodb-js/my-queries-storage';
 import type { QueryOptionOfTypeDocument } from '../constants/query-option-definition';
 
-type AutoCompleteQuery<T extends { _lastExecuted: Date }> = Partial<T> &
-  Pick<T, '_lastExecuted'>;
+type AutoCompleteQuery<T extends { _lastExecuted: Date }> = Partial<T> & {
+  _lastExecuted: Date;
+};
 type AutoCompleteRecentQuery = AutoCompleteQuery<RecentQuery>;
 type AutoCompleteFavoriteQuery = AutoCompleteQuery<FavoriteQuery>;
 

packages/reflux-state-mixin/src/store-mixin.ts

@@ -12,11 +12,13 @@ export type StoreWithStateMixin<T extends Record<string, unknown>> =
 
 function attachAction<T extends Record<string, unknown>>(
   this: StoreWithStateMixin<T>,
-  actionName: string & keyof T
+  actionName: keyof T
 ) {
   if (this[actionName]) {
     // eslint-disable-next-line no-console
-    console.warn('Not attaching event ' + actionName + '; key already exists');
+    console.warn(
+      'Not attaching event ' + String(actionName) + '; key already exists'
+    );
     return;
   }
   this[actionName] = Reflux.createAction();