Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ActiveSupport::Cache::MonetaStore: Rails 6 support - Implement/advertise cache versioning support #186

Open
jimcavoli opened this issue Jun 10, 2020 · 2 comments
Labels

Comments

@jimcavoli
Copy link

Introduced by rails/rails#33932 for Rails 6, without implementing a .supports_cache_versioning? on ActiveSupport::Cache::MonetaStore, the application will raise an exception encouraging the user to change adapters entirely or alternatively disable recyclable cache keys (see rails/rails#29092).

The only notable change is that the passed ActiveSupport::Cache::Entry includes a version attribute (readable) that contains the version part of the cache key so that cache keys remain the same for particular entries.

@jimcavoli jimcavoli changed the title Implement/advertise cache versioning support ActiveSupport::Cache::MonetaStore: Rails 6 support - Implement/advertise cache versioning support Jun 10, 2020
@asppsa asppsa added the Feature label Jun 10, 2020
@asppsa
Copy link
Collaborator

asppsa commented Jun 10, 2020

Thanks for bringing this to my attention - I had no idea this had been added to Rails!

@asppsa
Copy link
Collaborator

asppsa commented Jun 17, 2020

I think this basically boils down to being able to store version metadata in the cache, and to check that version against a supplied one when fetching. This may mean it's possible to implement on top of #107.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants