-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cnspec exits when too much args are specified #171
Comments
czunker
added a commit
to mondoohq/cnquery
that referenced
this issue
Nov 8, 2022
Fixes mondoohq/cnspec#171 Signed-off-by: Christian Zunker <[email protected]>
The fix mondoohq/cnquery#453 would be needed for each action command. The other option would be to remove the optional @scottford-io / @chris-rock Opinions? |
That is a problem that needs to be fixed in the GitHub action. This would add a wrong behaviour to cnquery / cnspec |
czunker
added a commit
to mondoohq/actions
that referenced
this issue
Nov 9, 2022
Fixes mondoohq/cnspec#171 Signed-off-by: Christian Zunker <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
When we call cnspec from inside a GitHub action, the action might add an empty arg to the command, e.g.:
This results in an error:
This happens, because the action allows the user to specify additional args/parameters:
https://github.com/mondoohq/actions/pull/40/files#diff-d39e3d8374eded08ccdff5f7a8615006dd4d646d94f4eea996e30dca97790669R42
But, when nothing is specified it results in an empty arg
""
.To Reproduce
Steps to reproduce the behavior:
Expected behavior
cnspec should ignore the empty arg.
Additional context
Failed action job: https://github.com/mondoohq/actions/actions/runs/3419398794/jobs/5692869897
Looks similar to this one: actions/runner#924
The text was updated successfully, but these errors were encountered: