Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary line #21

Open
thisiskaransgit opened this issue Jan 31, 2023 · 8 comments · May be fixed by #26
Open

Remove unnecessary line #21

thisiskaransgit opened this issue Jan 31, 2023 · 8 comments · May be fixed by #26

Comments

@thisiskaransgit
Copy link

Steps to Reproduce

  1. Go to https://moja-global.github.io/Handbook/Chapter5/section_two.html
  2. Read the Prerequisite section

Remove ## GCBM Installation Guide

Screenshot from 2023-01-31 20-39-49

@BhaswatiRoy
Copy link
Contributor

Hello @thisiskaransgit
I can work on this

@shloka-gupta
Copy link
Member

@thisiskaransgit thanks for pointing it out you'd like to work on it let us know

@thisiskaransgit
Copy link
Author

@chicken-biryani, I'm preoccupied with other things as of now kindly assign @BhaswatiRoy for this!

@shloka-gupta
Copy link
Member

@BhaswatiRoy please feel free to take it up. It's a good small issue to get well acquainted with the stack.

@BhaswatiRoy
Copy link
Contributor

Hey @chicken-biryani
I opened a pr last week and made the required changes from the review
#20
But it's not merged yet, and since I didn't create a separate branch, the contents for this one will go to that pr.
Do I need to wait for the pr to get merged?

@shloka-gupta
Copy link
Member

@BhaswatiRoy you can create a seperate branch.

We'll try and merge the PR asap.

Since the handbook is new a very good contribution would be to go through it... Read it... Understand... And let us know where you think we could improve.

Don't hesitate, I know at some point you may think, "Am I asking a silly question"... But you aren't. We want to make the handbook as beginner friendly as possible.

@BhaswatiRoy
Copy link
Contributor

Thank you @chicken-biryani
I will make these changes in a new branch

@BhaswatiRoy BhaswatiRoy mentioned this issue Feb 1, 2023
@BhaswatiRoy
Copy link
Contributor

hello @chicken-biryani
I created a new branch and submitted the pr

@BhaswatiRoy BhaswatiRoy linked a pull request Feb 20, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants