Skip to content

Context manager should not suppress exceptions #426

Open
@nazarewk

Description

@nazarewk

Description

def __exit__(self, exc_type, exc_value, traceback):
"""
Releases the lock - with best_effort=True
"""
logger.debug('Exiting: %s', self.unique_identifier)
self.release(best_effort=True)
return True

I don't think context manager should suppress exceptions, makes for very annoying debugging experience and error handling.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions