Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a .dockerignore #94

Open
kinow opened this issue Jun 6, 2022 · 1 comment
Open

Add a .dockerignore #94

kinow opened this issue Jun 6, 2022 · 1 comment

Comments

@kinow
Copy link

kinow commented Jun 6, 2022

Hi!

Congrats for thor! Learned about it from HackerNews, and was surprised by the quality of the code! 👏

I think a .dockerignore file could be helpful, to avoid including unnecessary files in the build context.

Refs:

I tried to quickly run thor using the Docker image, but stopped it when the last layer started downloading 1.3 GB 😅 Will leave it for when I'm connected to $work's network to save my bandwidth.

Cheers
Bruno

@mjuric
Copy link
Collaborator

mjuric commented Jun 10, 2022

Hi @kinow -- just to quickly let you know we've seen the PR (and thanks for sending it in!). @moeyensj has been on a (well deserved!) vacation for the last week, and he'll check it out & merge as soon as he's back.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants