[docs] update broken link to nightly branch #3885
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- changed the link from `main` to `nightly` for the operators example Signed-off-by: Miguel Cárdenas <[email protected]>
miguelcsx
force-pushed
the
refactor/update-broken-list
branch
from
826406a to
a834308
Compare
|
Sorry for the delay on this. This link was designed to work correctly when 24.6 was released (and it does work now). But now that we have nightly docs on the public site, we need to improve our tooling so we can have the nightly docs link to the nightly branch of the repo, and automatically switch that link when we build the release docs. So I think we do want to link to the nightly branch here. !sync |
modularbot
added
the
imported-internally
|
✅🟣 This contribution has been merged 🟣✅ Your pull request has been merged to the internal upstream Mojo sources. It will be reflected here in the Mojo repository on the nightly branch during the next Mojo nightly release, typically within the next 24-48 hours. We use Copybara to merge external contributions, click here to learn more. |
modularbot
added
the
merged-internally
modularbot
added a commit
that referenced
this pull request
Jan 11, 2025
[External] [docs] update broken link to nightly branch - The link to the example of implementing operators for a custom type was broken, as it pointed to the `main` branch. - Updated the URL to point to the correct `nightly` branch, ensuring the link now leads to the correct example: https://github.com/modularml/mojo/tree/nightly/examples/operators - The change was made on the page: https://docs.modular-dev.com/nightly/mojo/manual/operators/#an-example-of-implementing-operators-for-a-custom-type ORIGINAL_AUTHOR=Miguel Cárdenas <[email protected]> PUBLIC_PR_LINK=#3885 Co-authored-by: Miguel Cárdenas <[email protected]> Closes #3885 MODULAR_ORIG_COMMIT_REV_ID: 24c0200789225bff5266771ede4f8994f3a94260
|
Landed in dbd90f6! Thank you for your contribution 🎉 |
modularbot
added a commit
that referenced
this pull request
Feb 13, 2025
[External] [docs] update broken link to nightly branch - The link to the example of implementing operators for a custom type was broken, as it pointed to the `main` branch. - Updated the URL to point to the correct `nightly` branch, ensuring the link now leads to the correct example: https://github.com/modularml/mojo/tree/nightly/examples/operators - The change was made on the page: https://docs.modular-dev.com/nightly/mojo/manual/operators/#an-example-of-implementing-operators-for-a-custom-type ORIGINAL_AUTHOR=Miguel Cárdenas <[email protected]> PUBLIC_PR_LINK=#3885 Co-authored-by: Miguel Cárdenas <[email protected]> Closes #3885 MODULAR_ORIG_COMMIT_REV_ID: 24c0200789225bff5266771ede4f8994f3a94260
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mainbranch.nightlybranch, ensuring the link now leads to the correct example: https://github.com/modularml/mojo/tree/nightly/examples/operators