-
Notifications
You must be signed in to change notification settings - Fork 655
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FEAT-#4605: Handle small and empty dataframes #4606
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@naren-ponder Would it be possible to transition this to using the query compiler approach? At the moment, this looks like the empty_dataframe.py
file is a lot of shared code with the dataframe.py
file, except for all the default_to_pandas. It might be easier to default to pandas at the query compiler since the base object already does that automatically.
Great! Looking forward to see these changes in |
This pull request introduces 11 alerts when merging 90ca31181c9c76b0ec27a3fc551356f9df9e4870 into 3982306 - view on LGTM.com new alerts:
|
This pull request introduces 11 alerts when merging fc42bd4d1a1024b6b6b6fa2503385b6a313dcbd4 into eddfda4 - view on LGTM.com new alerts:
|
@naren-ponder Any plans here? |
Signed-off-by: Naren Krishna <[email protected]>
Signed-off-by: Naren Krishna <[email protected]>
Signed-off-by: Naren Krishna <[email protected]>
Signed-off-by: Naren Krishna <[email protected]>
Signed-off-by: Naren Krishna <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #4606 +/- ##
===========================================
+ Coverage 71.43% 87.43% +16.00%
===========================================
Files 259 261 +2
Lines 19198 19609 +411
===========================================
+ Hits 13714 17146 +3432
+ Misses 5484 2463 -3021
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
@naren-ponder were you planning to add any tests to this PR? |
Any progress here? |
@Garra1980 yes, @Billy2551 is going to be taking this on. It'll probably be in a new PR, but we will keep this one up for now. |
@naren-ponder, do you have a plan to continue this? |
Closing as #5113 is based on ideas from the PR |
Signed-off-by: Naren Krishna [email protected]
What do these changes do?
flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
git commit -s
docs/development/architecture.rst
is up-to-date