FEAT-#4574: Warn users when pre-initialized Ray cluster is not using all available memory #4575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -219,6 +219,17 @@ def initialize_ray( | |||
| if not GPU_MANAGERS: | |||
| for i in range(GpuCount.get()): | |||
| GPU_MANAGERS.append(GPUManager.remote(i)) | |||
| else: | |||
| ray_obj_store_mem = ray.available_resources()["object_store_memory"] | |||
| virtual_memory = psutil.virtual_memory().total | |||
There was a problem hiding this comment.
Actually, in this context you might want to use available since there could be other processes running that are consuming memory?
There was a problem hiding this comment.
Free vs. available memory in Linux: https://haydenjames.io/free-vs-available-memory-in-linux/
Codecov Report
@@ Coverage Diff @@
## master #4575 +/- ##
==========================================
+ Coverage 86.22% 89.40% +3.18%
==========================================
Files 228 229 +1
Lines 18451 18727 +276
==========================================
+ Hits 15909 16743 +834
+ Misses 2542 1984 -558
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
… using all available memory Signed-off-by: Rehan Durrani <[email protected]>
Signed-off-by: Rehan Durrani <[email protected]>
Signed-off-by: Rehan Durrani <[email protected]>
|
@RehanSD what's the status of this PR? |
|
@vnlitvinov it's ready for review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Rehan Durrani [email protected]
What do these changes do?
flake8 modin/ asv_bench/benchmarks scripts/doc_checker.pyblack --check modin/ asv_bench/benchmarks scripts/doc_checker.pygit commit -sdocs/development/architecture.rstis up-to-date