Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update @web/dev-server-esbuild dependencie esbuild to v0.21 #2725

Closed
mantou132 opened this issue May 7, 2024 · 2 comments
Closed

Update @web/dev-server-esbuild dependencie esbuild to v0.21 #2725

mantou132 opened this issue May 7, 2024 · 2 comments

Comments

@mantou132
Copy link

esbuild v0.21 support javascript decorators, this is useful for testing some decorator-based frameworks

evanw/esbuild#104 (comment)

@Westbrook
Copy link
Member

Would you be interested in making a contribution with this update?

@favna
Copy link

favna commented Jul 13, 2024

From a quick test done by setting esbuild to ~0.21.5 in my package resolutions and nothing breaking outright I think it's as easy as just bumping the dependency and no breaking changes are incurred for web-dev-server but I can't say for sure.

  • v0.20 of esbuild only affects Deno users
  • v0.21 is the introduction of decorators and is considered breaking by Evan because when the developer desires the old style decorators implemented by TypeScript they have to add experimentalDecorators in their tsconfig (just like they would have to when using TS >5.0)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants