Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test Runner 'manual' mode import path is not relative to rootPath #2721

Open
jahorton opened this issue Apr 30, 2024 · 0 comments
Open

Test Runner 'manual' mode import path is not relative to rootPath #2721

jahorton opened this issue Apr 30, 2024 · 0 comments

Comments

@jahorton
Copy link

jahorton commented Apr 30, 2024

I discovered this one alongside #2720.

If I try to use manual to inspect a test, the import path is based upon the absolute local filesystem path, regardless of what rootPath is set to. This can cause the imports to fail, only for manual mode, if rootPath is not a root directory, as the file is actually served based on its path from rootPath, not its full, absolute local filesystem path.

This appears to be handled correctly for standard testing; it's only an issue for manual mode.

Discovered with v0.18.1.

Suppose the following setup:

  • C:/
    • a/
      • b/
        • c/
          • d/
            • e/
              • f/
              • myTest.spec.mjs
            • my.config.mjs (with repoRoot: "../../" [or C://a/b/])

(For Windows fanatics, feel free to replace the /s with \s at your leisure.)

With repoRoot resolving to C://a/b, the automatic testing mode (manual: false) will handle all paths perfectly. However, the manual path will fail to resolve /c/d/e/f/myTest.spec.mjs or similar paths when importing test spec files. Directly inputting http://localhost:8000/c/d/e/f/myTest.spec.mjs will resolve properly and show the resource in-browser, but the manual test page's import will be /a/b/c/d/e/f/myTest.spec.mjs, as viewable via element/source inspection of the host page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant