Commit ed897fa
Veerendra Kumar
fix: return 405 for pre-session GET the server won't serve as SSE
The Streamable HTTP spec requires a GET the server does not serve as an
SSE stream to get 405 Method Not Allowed, but in stateful mode a
pre-session GET returned 400 (missing session ID) instead. Only-405 is
what client transports (e.g. the TypeScript SDK's SSE probe) treat as
the graceful fall-through to POST, so stock servers aborted those
handshakes before initialize.
Return 405 with Allow: GET, POST, DELETE for session-less GETs in
stateful mode, before Accept validation, matching the Allow value of
_handle_unsupported_request. (The 406-for-wildcard-Accept arm of the
report is already fixed on main via check_accept_headers.)
Closes #31021 parent a4f4ccd commit ed897fa
4 files changed
Lines changed: 80 additions & 3 deletions
File tree
- src/mcp/server
- tests
- interaction
- transports
- server
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
690 | 690 | | |
691 | 691 | | |
692 | 692 | | |
| 693 | + | |
| 694 | + | |
| 695 | + | |
693 | 696 | | |
694 | 697 | | |
695 | 698 | | |
696 | 699 | | |
697 | 700 | | |
| 701 | + | |
| 702 | + | |
| 703 | + | |
| 704 | + | |
| 705 | + | |
| 706 | + | |
| 707 | + | |
| 708 | + | |
| 709 | + | |
| 710 | + | |
| 711 | + | |
| 712 | + | |
| 713 | + | |
| 714 | + | |
| 715 | + | |
698 | 716 | | |
699 | 717 | | |
700 | 718 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3165 | 3165 | | |
3166 | 3166 | | |
3167 | 3167 | | |
| 3168 | + | |
| 3169 | + | |
| 3170 | + | |
| 3171 | + | |
| 3172 | + | |
| 3173 | + | |
| 3174 | + | |
| 3175 | + | |
| 3176 | + | |
| 3177 | + | |
3168 | 3178 | | |
3169 | 3179 | | |
3170 | 3180 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
95 | 95 | | |
96 | 96 | | |
97 | 97 | | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
| 136 | + | |
| 137 | + | |
| 138 | + | |
| 139 | + | |
| 140 | + | |
| 141 | + | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
| 145 | + | |
98 | 146 | | |
99 | 147 | | |
100 | 148 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
124 | 124 | | |
125 | 125 | | |
126 | 126 | | |
127 | | - | |
128 | | - | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
129 | 130 | | |
130 | | - | |
| 131 | + | |
0 commit comments