Skip to content

Commit 95d778a

Browse files
Fatima ArkinFatima Arkin
authored andcommitted
add short comment explaining NoopASGI usage
1 parent c814e1f commit 95d778a

File tree

2 files changed

+2
-0
lines changed

2 files changed

+2
-0
lines changed

tests/server/test_sse_security.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -56,6 +56,7 @@ async def handle_sse(request: Request) -> NoopASGI:
5656
except ValueError as e:
5757
# Validation error was already handled inside connect_sse
5858
logger.debug(f"SSE connection failed validation: {e}")
59+
# connect_sse already responded; return a no-op ASGI endpoint
5960
return NoopASGI()
6061

6162
routes = [

tests/shared/test_sse.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -95,6 +95,7 @@ def create_sse_app(server: Server) -> Starlette:
9595
async def handle_sse(request: Request) -> NoopASGI:
9696
async with sse.connect_sse(request.scope, request.receive, request._send) as streams:
9797
await server.run(streams[0], streams[1], server.create_initialization_options())
98+
# connect_sse already responded; return a no-op ASGI endpoint
9899
return NoopASGI()
99100

100101
return Starlette(

0 commit comments

Comments
 (0)