-
Notifications
You must be signed in to change notification settings - Fork 264
support http://json-schema.org/draft-07/schema# #220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support http://json-schema.org/draft-07/schema# #220
Conversation
936df35 to
a8a7ab3
Compare
|
Wow, this is amazing! Thanks so much. Can you tell me how you wrote this code? Did you have a draft 07 implementation lying around or did you just read the specs and diff them? Either way, I'm going to read the draft 07 spec carefully myself to check your implementation, and then we'd be very happy to accept it. I hope to get to this early next week. |
|
Honestly, I just had Claude code read the two drafts, asked it to diff them, and then had it update the impl to support both. I had to give it a new test (existing MCPs that were use draft 07), but then I asked it to loop until both the existing and new tests were passing. I mostly just sanity checked the output but if this is on the right track then I can do some more work. I think it's probably important for adoption because I'm seeing lots of MCP servers in the wild that will need this support. Over the next few days, I'll have a test base of about 150 MCP servers that I can connect to with this client. From my tests so far, there are 3 things that come up:
|
|
Sounds good! |
|
@slimslenderslacks Please open this at github.com/google/jsonschema-go. If you don't want to, let me know and I'll do it. But then I will be the committer. (I will make you co-author of course.) |
|
Cool! Will open this now. |
|
Thanks. And how about adding the test suite? We can't accept the PR without it. |
|
Right, I'll try to get back to a test suite later today. I guess we'll just close the pull request, right? |
|
Yup! |
We can not connect to some MCP servers, such as mongodb and playwright, because we cannot validate against this draft.
I heard from @jba that we will be moving this module out of the schema, but in the short term, the number of MCP servers that we can be limited.