Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker-proxy-close-dangling-sockets #2465

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

meermonster10
Copy link

@meermonster10 meermonster10 commented Oct 10, 2019

Make docker-proxy more resilient to CLOSE_WAIT and FIN_WAIT2 socket states.
In case of unexpected connection terminations, do not wait indefinitely until both ends are closed.
Signed-off-by: Jason Kim [email protected]

Make docker-proxy more resilient to CLOSE_WAIT and FIN_WAIT2 socket states.
In case of unexpected connection terminations, do not wait indefinitely until both ends are closed.
@GordonTheTurtle
Copy link

Please sign your commits following these rules:
https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:

$ git clone -b "patch-1" [email protected]:meermonster10/libnetwork.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

meermonster10 and others added 2 commits October 10, 2019 00:56
Make docker-proxy more resilient to CLOSE_WAIT and FIN_WAIT2 socket states.
In case of unexpected connection terminations, do not wait indefinitely until both ends are closed.

Signed-off-by: Jason Kim <[email protected]>
@Zer0t3ch
Copy link

ss is showing my server full of CLOSE-WAIT connections from docker-proxy causing kernel TCP out of memory. Would this modification presumably solve that problem, and when could we expect it to hit stable?

@Atl4sx
Copy link

Atl4sx commented Jul 13, 2020

+1

1 similar comment
@litzk
Copy link

litzk commented Sep 10, 2020

+1

@cpuguy83
Copy link
Member

Note we have migrated this codebase over to github.com/moby/moby/libnetwork.
We are not accepting PR's on this repo anymore except for backports to be included in moby 20.10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants