Setting Filesystem

[alexs-sentrytechnology]

Hi,

Wanted to propose an option here - I use LittleFS in my ESP8266 code - and a few times now i've migrated environments on my build machine, pulled in a clean copy of the firebase esp client library and it's reset the littlefs customisation in FirebaseFS.h. Then (because i'm slow) i spend a day tracking down issues around the storage.download code only to track back to the FirebaseFS.h using a different filesystem. I think it would be good to define the right library in my code without having to edit the library code.

Currently - FirebaseFS.h automatically defines DEFAULT_FLASH_FS SPIFFS by default. Is it possible to look for some defines before making that default define? e.g. in my code i could define FIREBASE_FS_LITTLEFS (and other options) before including the firebase libraries which the library could then pick up and use the right library without me having to edit the library code. If no defines are found - it could then use the current default settings?

Cheers
Alex

[mobizt]

You should read the comments in all examples and the Readme doc that already describe how to configure the filesystem.

This library is not a single header library that all classes and functions are in only one header file i.e., Firebase_ESP_Client.h.

This is normal approach when you use library that contains many headers and sources files, which all definition macros that used to control the library compilation are included in a header file in the library which user may change it for different compilation options.

The macro that defined in FirebaseFS.h included the filesystems definitions, are not only used in Firebase_ESP_Client.h but used by other codes in headers and source files of this library which the macro defined before including Firebase_ESP_Client.h can use only in Firebase_ESP_Client.h file scope, other headers and sources files included in Firebase_ESP_Client.h are in different scope and can't see this macro definition.

That is why FirebaseFS.h is the suitable place to define everything instead of user sketch.

Before update the library, you should backup your version of FirebaseFS.h file and replace it in the library after update.

[alexs-sentrytechnology]

Thanks. Yes - i think i understand your advice.

Just to be clear - i was not suggesting to replace the #defines in FirebaseFS.h - but to allow the user to flag the filesystem them in their code and avoid editing the FirebaseFS.h. If there was a #define USER_DEFINE_FLAG_LITTLEFS for example - the relevant part of FirebaseFS.h would become :

#if defined(ESP32)
#include <SPIFFS.h>
#endif
#if defined(ESP32) || defined(ESP8266)

  #if USER_DEFINE_FLAG_LITTLEFS 
    #include <littlefs.h>
    #define DEFAULT_FLASH_FS LITTLEFS
  #else
    #define DEFAULT_FLASH_FS SPIFFS
  #endif

#endif

That way - the user wouldnt have to be editing files in the library (just adding defines in their code before including the firebase client library).

Cheers
Alex

[mobizt]

As I wrote before, other headers and sources files included in Firebase_ESP_Client.h can't see your USER_DEFINE_FLAG_LITTLEFS when they included FirebaseFS.h to use the same definitions in that file.

[mobizt]

Your approach is possible when using with single header library.

[alexs-sentrytechnology]

Ahh ok - i get it. Thanks.. For others thinking something similar - i have created the following in my code (not the library)

#ifndef FIREBASE_FS_DEFINED
    //need to update FirebaseFS.h to use littlefs
    #error FIREBASE_FS_DEFINED not defined in FirebaseFS.h
#endif

I define FIREBASE_FS_DEFINED in FirebaseFS.h when i make the change to LittleFS.

It's a clunky way to get alerted to the fact i havent modified the file.

Cheers
Alex