Fix CodeQL security findings and exclude third-party code#184
Merged
Conversation
- Fix 31 stack trace exposure alerts: replace str(e) with generic error messages in landing app, network routes, and cybicsagent - Fix 2 path injection alerts: add safe_join and path validation for training content file serving routes - Fix 1 polynomial ReDoS: bound regex repetition in cybicsagent - Fix 2 clear text password logging alerts in OPC-UA tests - Exclude OpenPLC_v3 third-party code from CodeQL analysis via codeql-config.yml (32 alerts in upstream code we don't maintain) - Document 2 intentional findings: webshell command execution and MITM proxy bind-all-interfaces Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
safe_join+ path validationTest plan
🤖 Generated with Claude Code