Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement a lint script #192

Open
brunobuddy opened this issue Oct 2, 2024 · 6 comments
Open

Implement a lint script #192

brunobuddy opened this issue Oct 2, 2024 · 6 comments
Assignees
Labels

Comments

@brunobuddy
Copy link
Contributor

Implement a a lint script to be run from the root folder with https://turbo.build/

We should be able to run npm run lint or turbo lint to lint all files based on our prettier config.

@nitesh2920
Copy link

If this issue is still open, please assign it to me. @brunobuddy

@nitesh2920
Copy link

npm packages are giving error while installing @brunobuddy .
image

@brunobuddy
Copy link
Contributor Author

Hi @nitesh2920 as of today we did not make it compatible with Windows, only with Mac and Linux.

I will check that soon.

@brunobuddy
Copy link
Contributor Author

@nitesh2920 the 4.0.4 version of Manifest is now compatible with Windows 😃

@nitesh2920
Copy link

@brunobuddy okay

@brunobuddy
Copy link
Contributor Author

Installed Husky on PR #232 with auto linting for several packages:

  • add-manifest
  • core/admin
  • core/helpers
  • core/json-schema
  • core/types
  • core/manifest
  • js-sdk

@brunobuddy brunobuddy mentioned this issue Nov 21, 2024
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants