fix: modify replaceBindings logic to fit current laravel implementation.

Author: chris-lee-lb

.travis.yml

@@ -1,20 +1,47 @@
 language: php
+
 php:
   - 7.2
   - 7.3
   - 7.4
   - 8.0
   - 8.1
 
-# Commands to be run before your environment runs.
-before_script:
+laravel:
+  - 10.*
+  - 9.*
+  - 8.*
+  - 7.*
+  - 6.*
+  - 5.*
+
+jobs:
+  exclude:
+    # Unsupported combinations
+    - { laravel: 5.*, php: 8.0 }
+    - { laravel: 5.*, php: 8.1 }
+    - { laravel: 6.*, php: 8.1 }
+    - { laravel: 7.*, php: 8.1 }
+    - { laravel: 8.*, php: 7.2 }
+    - { laravel: 9.*, php: 7.2 }
+    - { laravel: 9.*, php: 7.3 }
+    - { laravel: 9.*, php: 7.4 }
+    - { laravel: 10.*, php: 7.2 }
+    - { laravel: 10.*, php: 7.3 }
+    - { laravel: 10.*, php: 7.4 }
+    - { laravel: 10.*, php: 8.0 }
+
+before_install:
   - composer self-update
   - rm composer.lock
-  - composer install --no-interaction
+
+install:
+  - travis_retry composer require --dev "laravel/framework:${laravel}" --no-interaction
+  - travis_retry composer install --no-interaction
 
 script:
- - mkdir -p build/logs
- - php vendor/bin/phpunit --coverage-clover build/logs/clover.xml
+  - mkdir -p build/logs
+  - php vendor/bin/phpunit --coverage-clover build/logs/clover.xml
 
 after_script:
- - php vendor/bin/php-coveralls -v
+  - php vendor/bin/php-coveralls -v

src/Objects/Concerns/ReplacesBindings.php

@@ -19,7 +19,7 @@ protected function replaceBindings($sql, array $bindings)
         $generalRegex = $this->getRegex();
 
         foreach ($this->formatBindings($bindings) as $key => $binding) {
-            $regex = is_numeric($key) ? $generalRegex : $this->getNamedParameterRegex($key);
+            $regex = is_int($key) ? $generalRegex : $this->getNamedParameterRegex($key);
             $sql = preg_replace($regex, $this->value($binding), $sql, 1);
         }
 
@@ -43,7 +43,7 @@ protected function value($value)
             return (int) $value;
         }
 
-        return is_numeric($value) ? $value : "'" . $value . "'";
+        return is_int($value) ? $value : "'" . $value . "'";
     }
 
     /**

tests/Objects/SqlQueryTest.php

@@ -53,7 +53,7 @@ public function it_returns_valid_query_with_replaced_bindings()
 
         $expectedSql = <<<EOF
 SELECT * FROM tests WHERE a = '\'test' AND CONCAT('{$bindings[1]->toDateTimeString()}', '%'
- , '{$bindings[2]->format('Y-m-d H:i:s')}') = 453 AND column = 67.23
+ , '{$bindings[2]->format('Y-m-d H:i:s')}') = 453 AND column = '67.23'
 EOF;
 
         $this->assertSame($expectedSql, $query->get());
@@ -72,7 +72,7 @@ public function it_returns_valid_query_with_replaced_bindings_for_immutable_date
 
         $expectedSql = <<<EOF
 SELECT * FROM tests WHERE a = '\'test' AND CONCAT('{$bindings[1]->toDateTimeString()}', '%'
- , '{$bindings[2]->format('Y-m-d H:i:s')}') = 453 AND column = 67.23
+ , '{$bindings[2]->format('Y-m-d H:i:s')}') = 453 AND column = '67.23'
 EOF;
 
         $this->assertSame($expectedSql, $query->get());